You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/01/08 17:20:28 UTC

[GitHub] [nifi] exceptionfactory commented on pull request #5620: NIFI-9267 Replaced nifi-standard-web-test-utils with mockwebserver

exceptionfactory commented on pull request #5620:
URL: https://github.com/apache/nifi/pull/5620#issuecomment-1008069814


   > Thanks for this update, @exceptionfactory, it looks cleaner to use the MockWebServer rather than the custom TestServer. The tests all pass. +1 for me, once the merge conflicts are resolved!
   
   Thanks for the review @gresockj! I rebased to resolve the conflicts, and also consolidated the three AWS Gateway classes into a single class that contains two additional methods.  This ensures that all three types of credentials get tested without running through every single test method three times.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org