You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by skunert <gi...@git.apache.org> on 2014/06/19 16:04:58 UTC

[GitHub] incubator-flink pull request: SemanticProperties for Projections

GitHub user skunert opened a pull request:

    https://github.com/apache/incubator-flink/pull/29

    SemanticProperties for Projections

    This PR deals with
    https://issues.apache.org/jira/browse/FLINK-932
    
    ProjectionJoins, Crosses and the regular project operator get their SemanticProperties generated automatically. Additionally, I disables withConstantSet() for ProjectJoins and Crosses because it can cause conflicts.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skunert/incubator-flink projection_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
    
----
commit 73e14235fb40fd76a7a2bb57ba07eca0f23421d8
Author: sebastian kunert <sk...@gmail.com>
Date:   2014-06-19T13:59:36Z

    introduced automaitc generation of semantic props for projections

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: SemanticProperties for Projections

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/29#discussion_r14508478
  
    --- Diff: stratosphere-java/src/main/java/eu/stratosphere/api/java/operators/JoinOperator.java ---
    @@ -510,6 +522,16 @@ protected ProjectJoin(DataSet<I1> input1, DataSet<I2> input2, Keys<I1> keys1, Ke
     					new ProjectJoinFunction<I1, I2, OUT>(fields, isFromFirst, returnType.createSerializer().createInstance()), 
     					returnType, hint);
     		}
    +
    +		@Override
    +		public JoinOperator<I1, I2, OUT> withConstantSetFirst(String... constantSetFirst) {
    +			throw new RuntimeException("Please do not use ConstantFields on ProjectJoins. The Fields are automatically calculated.");
    --- End diff --
    
    You can skip the "please". No need for the API to kindly ask for something. Use something like "The Semantic properties (constant and forwarded fields) are automatically calculated on projection joins."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: SemanticProperties for Projections

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/29


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: SemanticProperties for Projections

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/29#issuecomment-47894397
  
    Looks good. I will merge that and address the comment of changing the exception message myself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---