You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/11 06:30:13 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4425: Setting snapshot state to error on timeout

sureshanaparti commented on a change in pull request #4425:
URL: https://github.com/apache/cloudstack/pull/4425#discussion_r521139517



##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -587,6 +590,7 @@ protected Answer copySnapshot(DataObject srcData, DataObject destData) {
             if (cacheData != null) {
                 cacheMgr.deleteCacheObject(cacheData);
             }
+            _snapshotService.markFailedSnapshot(destData.getId());

Review comment:
       @Spaceman1984 the copy callback should mark the snapshot state accordingly, based on the operation result (success / fail). Not required to set the state explicitly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org