[jira] Commented: (ZOOKEEPER-472) Making DataNode not instantiate a HashMap when the node is ephmeral

["Patrick Hunt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765676#action_12765676 ] 

Patrick Hunt commented on ZOOKEEPER-472:
----------------------------------------

Hi, what's the status on this JIRA? I'd like to get it reviewed/committed if it's ready. (you need to "submit patch", I would do it, but I can't as you've marked it as "in progress")

we use 4 spaces, for some reason hadoop mr/hdfs uses 2 but we use 4 (you should see this used throughout our code)

Thanks!


> Making DataNode not instantiate a HashMap when the node is ephmeral
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-472
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-472
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.1.1, 3.2.0
>            Reporter: Erik Holstad
>            Assignee: Erik Holstad
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: zookeeper-472.patch
>
>
> Looking at the code, there is an overhead of a HashSet object for that nodes children, even though the node might be an ephmeral node and cannot have children.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.