You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Amareshwari Sriramadasu <am...@yahoo-inc.com> on 2010/09/07 11:59:54 UTC
Review Request: HIVE-537 Hive TypeInfo/ObjectInspector to support union
(besides struct, array, and map)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/795/
-----------------------------------------------------------
Review request for Hive Developers.
Summary
-------
Adds Union type to Standard ObjectInSpectors, TypeInfo and Lazy ObjectInspectors.
This addresses bug HIVE-537.
http://issues.apache.org/jira/browse/HIVE-537
Diffs
-----
trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/Constants.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUnion.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspector.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObject.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObjectInspector.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 991812
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/UnionTypeInfo.java PRE-CREATION
trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java 991812
trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 991812
Diff: http://review.cloudera.org/r/795/diff
Testing
-------
Thanks,
Amareshwari
Re: Review Request: HIVE-537 Hive TypeInfo/ObjectInspector to support union
(besides struct, array, and map)
Posted by Amareshwari Sriramadasu <am...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/795/
-----------------------------------------------------------
(Updated 2010-09-28 22:27:00.514119)
Review request for Hive Developers.
Changes
-------
Updated diff with suggested changes.
Summary
-------
Adds Union type to Standard ObjectInSpectors, TypeInfo and Lazy ObjectInspectors.
This addresses bug HIVE-537.
http://issues.apache.org/jira/browse/HIVE-537
Diffs (updated)
-----
trunk/data/files/union_input.txt PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1002189
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1002189
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1002189
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUnion.java PRE-CREATION
trunk/ql/src/test/queries/clientpositive/create_union_table.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/udf_union.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/create_union_table.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/show_functions.q.out 1002189
trunk/ql/src/test/results/clientpositive/udf_union.q.out PRE-CREATION
trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/Constants.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUnion.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspector.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObject.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObjectInspector.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 1002189
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/UnionTypeInfo.java PRE-CREATION
trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java 1002189
trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 1002189
Diff: http://review.cloudera.org/r/795/diff
Testing
-------
Thanks,
Amareshwari
Re: Review Request: HIVE-537 Hive TypeInfo/ObjectInspector to support union
(besides struct, array, and map)
Posted by Amareshwari Sriramadasu <am...@yahoo-inc.com>.
> On 2010-09-15 15:15:08, Zheng Shao wrote:
> > Overall looks like a good first step. We need to change Hive.g, add UDF etc to allow users to use it in the Hive language.
Zheng, there is already keyword (KW_UNION: 'UNION') used for doing union/union all operations. Do you think we should use a different keyword for specifying Union type?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/795/#review1231
-----------------------------------------------------------
On 2010-09-07 02:59:54, Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/795/
> -----------------------------------------------------------
>
> (Updated 2010-09-07 02:59:54)
>
>
> Review request for Hive Developers.
>
>
> Summary
> -------
>
> Adds Union type to Standard ObjectInSpectors, TypeInfo and Lazy ObjectInspectors.
>
>
> This addresses bug HIVE-537.
> http://issues.apache.org/jira/browse/HIVE-537
>
>
> Diffs
> -----
>
> trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/Constants.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUnion.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspector.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObject.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObjectInspector.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/UnionTypeInfo.java PRE-CREATION
> trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java 991812
> trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 991812
>
> Diff: http://review.cloudera.org/r/795/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari
>
>
Re: Review Request: HIVE-537 Hive TypeInfo/ObjectInspector to support union
(besides struct, array, and map)
Posted by Zheng Shao <zs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/795/#review1231
-----------------------------------------------------------
Overall looks like a good first step. We need to change Hive.g, add UDF etc to allow users to use it in the Hive language.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
<http://review.cloudera.org/r/795/#comment4192>
unioin -> union
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
<http://review.cloudera.org/r/795/#comment4193>
We cannot compare 2 union objects like this. We need to first compare their TAG. Only when the TAG is the same shall we compare the field.
- Zheng
On 2010-09-07 02:59:54, Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/795/
> -----------------------------------------------------------
>
> (Updated 2010-09-07 02:59:54)
>
>
> Review request for Hive Developers.
>
>
> Summary
> -------
>
> Adds Union type to Standard ObjectInSpectors, TypeInfo and Lazy ObjectInspectors.
>
>
> This addresses bug HIVE-537.
> http://issues.apache.org/jira/browse/HIVE-537
>
>
> Diffs
> -----
>
> trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/Constants.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUnion.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspector.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObject.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObjectInspector.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 991812
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/UnionTypeInfo.java PRE-CREATION
> trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java 991812
> trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 991812
>
> Diff: http://review.cloudera.org/r/795/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari
>
>