You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/19 23:20:44 UTC
[GitHub] [incubator-devlake] e2corporation opened a new pull request, #2783: feat: add connection rate limit setting
e2corporation opened a new pull request, #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783
### ⚠️ Config-UI / Data Integrations / Connections - **Rate Limit**
- [ ] Add Rate Limit Connection Form Field
- [ ] Update Connection Manager Hook (Define `rateLimit`)
- [ ] Update Component Properties
- [ ] Test Rate Limit Setting
### Description
This PR adds the **Rate Limit** (per hour) numeric setting for the **Connections** definition for All Data Providers (Plugins). The default value is `0`.
### Does this close any open issues?
#931
### Screenshots
<img width="1163" alt="Screen Shot 2022-08-19 at 7 19 03 PM" src="https://user-images.githubusercontent.com/1742233/185718577-4eda9747-a17d-40c0-a4c7-403ab3eb05ac.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2783: feat: add connection rate limit setting
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783#discussion_r950660149
##########
config-ui/src/data/NullConnection.js:
##########
@@ -21,6 +21,7 @@ const NullConnection = {
name: null,
endpoint: null,
proxy: null,
+ rateLimit: 0,
Review Comment:
@klesh changed request payload key to `rateLimitPerHour`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2783: feat: add connection rate limit setting | `Draft`
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783#issuecomment-1221169124
@klesh @warren830 Is BE currently storing rateLimit? It's still returning `0` even though request payload sends a different value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2783: feat: add connection rate limit setting
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783#discussion_r950659017
##########
config-ui/src/data/NullConnection.js:
##########
@@ -21,6 +21,7 @@ const NullConnection = {
name: null,
endpoint: null,
proxy: null,
+ rateLimit: 0,
Review Comment:
I looked at the code rateLimit is the key being used. The API response even sends back "rateLimit"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2783: feat: add connection rate limit setting
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783#issuecomment-1221248384
@klesh PR Updated ready to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #2783: feat: add connection rate limit setting
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783#discussion_r950658375
##########
config-ui/src/data/NullConnection.js:
##########
@@ -21,6 +21,7 @@ const NullConnection = {
name: null,
endpoint: null,
proxy: null,
+ rateLimit: 0,
Review Comment:
it should be ratelimitPerHour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #2783: feat: add connection rate limit setting
Posted by GitBox <gi...@apache.org>.
klesh merged PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2783: feat: add connection rate limit setting
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783#discussion_r950660211
##########
config-ui/src/data/NullConnection.js:
##########
@@ -21,6 +21,7 @@ const NullConnection = {
name: null,
endpoint: null,
proxy: null,
+ rateLimit: 0,
Review Comment:
@klesh Internally on UI we use `rateLimit`. It is defined correctly in `NullConnection`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2783: feat: add connection rate limit setting
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783#issuecomment-1221239739
:warning: NOTE: This PR may conflict with PR #2782. The changes on PR's #2782 `blueprint-settings.jsx` should be preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2783: feat: add connection rate limit setting
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2783:
URL: https://github.com/apache/incubator-devlake/pull/2783#discussion_r950659146
##########
config-ui/src/data/NullConnection.js:
##########
@@ -21,6 +21,7 @@ const NullConnection = {
name: null,
endpoint: null,
proxy: null,
+ rateLimit: 0,
Review Comment:
or only on the request payload it needs to be `ratelimitPerHour`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org