You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@clerezza.apache.org by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org> on 2010/01/25 09:13:34 UTC
[jira] Issue Comment Edited: (CLEREZZA-77) add Panel to HeadedPage
[ https://issues.apache.org/jira/browse/CLEREZZA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804436#action_12804436 ]
Reto Bachmann-Gmür edited comment on CLEREZZA-77 at 1/25/10 8:11 AM:
---------------------------------------------------------------------
wondering why the script is in org.apache.clerezza.web.resources.style and not org.apache.clerezza.web.resources.scripts, furthermore I can't see any reference to tx-panel-title in that script. Currently the only link between the title and the actual tab is that they have the same position within two containers, I think it would be better to have the title as the first chlld of the tab, e.g.
resultDocModifier.addNodes2Elem("tx-panel-detail", <div id="my-tab"><div class="tab-title">My tab title</div>My Tab</div>);
obviously we could also use h3 instead of <div class="tab-title">, but the level 3 seems a bit arbitrary to me, so I'd prefer class "tab-title", "tab-index" or "tab-button" (not sure if index or button is the more common word in this context)
was (Author: reto):
wondering why the script is in org.apache.clerezza.web.resources.style and not org.apache.clerezza.web.resources.scripts, furthermore I can't see any reference to tx-panel-title in that script. Currently the only link between the title and the actual tab is that they have the same position within two containers, I think it would be better to have the title as the first chlld of the tab, e.g.
resultDocModifier.addNodes2Elem("tx-panel-detail", <div id="my-tab"><div class="tab-title">My tab title</div>My Tab</div>);
obviously we could also use h3 instead of <div class="tab-title">, but the level 3 seems a bit arbitrary to me.
> add Panel to HeadedPage
> -----------------------
>
> Key: CLEREZZA-77
> URL: https://issues.apache.org/jira/browse/CLEREZZA-77
> Project: Clerezza
> Issue Type: New Feature
> Reporter: Tsuyoshi Ito
> Assignee: Tsuyoshi Ito
>
> add Panel to HeadedPage
> because of incompatibility with existing HeadedPage-Include-Templates , I propose a new Type called HeadedPageWithPanel.
> Problem:
> existing Includes have the structure:
> <div id="tx-content">
> <div>CONTENT</div>
> </div>
> they should consists of the inner div only.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.