You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Abhishek Kadam <ab...@gmail.com> on 2018/06/05 13:31:52 UTC

Review Request 67449: ATLAS-2731: UI : attributes on table's detailsPage buffers forever due no access on that entity type

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67449/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2731
    https://issues.apache.org/jira/browse/ATLAS-2731


Repository: atlas


Description
-------

BUG Description:

1. Create a Resource based policy for Atlas in Ranger with Entity-id as qualifiedName of a table, with all permissions , entity-type= * ,entity-classification=* for "admin" user. (Attached the screenshot of the policy)
2. Log into Atlas as admin and access table's detailsPage.
3. db attribute value keeps loading forever and there is an "admin is not authorized to perform read entity: guid=<db_guid>" error notification.

This patch includes changes handling 403 error and lookup in "relationshipAttribute" while rendering entity properties table.


Diffs
-----

  dashboardv2/public/js/utils/CommonViewFunction.js b8e023a 
  dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js aa6f5f4 
  dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 28eb749 


Diff: https://reviews.apache.org/r/67449/diff/1/


Testing
-------

1. UI testing done with two different users with different policies on types.
2. Tested lookup in "relationshipAttributes".


Thanks,

Abhishek Kadam


Re: Review Request 67449: ATLAS-2731: UI : attributes on table's detailsPage buffers forever due no access on that entity type

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67449/#review204320
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On June 5, 2018, 1:31 p.m., Abhishek Kadam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67449/
> -----------------------------------------------------------
> 
> (Updated June 5, 2018, 1:31 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2731
>     https://issues.apache.org/jira/browse/ATLAS-2731
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> BUG Description:
> 
> 1. Create a Resource based policy for Atlas in Ranger with Entity-id as qualifiedName of a table, with all permissions , entity-type= * ,entity-classification=* for "admin" user. (Attached the screenshot of the policy)
> 2. Log into Atlas as admin and access table's detailsPage.
> 3. db attribute value keeps loading forever and there is an "admin is not authorized to perform read entity: guid=<db_guid>" error notification.
> 
> This patch includes changes handling 403 error and lookup in "relationshipAttribute" while rendering entity properties table.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js b8e023a 
>   dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js aa6f5f4 
>   dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 28eb749 
> 
> 
> Diff: https://reviews.apache.org/r/67449/diff/1/
> 
> 
> Testing
> -------
> 
> 1. UI testing done with two different users with different policies on types.
> 2. Tested lookup in "relationshipAttributes".
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>