You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/19 08:20:25 UTC
[GitHub] [airflow] potiuk opened a new pull request #10399: Kubernetes image no embedded
potiuk opened a new pull request #10399:
URL: https://github.com/apache/airflow/pull/10399
The EMBEDDED dags were only really useful for testing
but it required to customise built production image
(run with extra --build-arg flag). This is not needed
as it is better to extend the image instead with FROM
and add dags afterwards. This way you do not have
to rebuild the image while iterating on it.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #10399: Kubernetes image no embedded
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #10399:
URL: https://github.com/apache/airflow/pull/10399#discussion_r472874790
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -240,9 +240,9 @@ function get_environment_for_builds_on_ci() {
export CI_BUILD_ID="0"
export CI_JOB_ID="default-job-id"
if [[ ${CI:=} != "true" ]]; then
- echo
- echo "This is not a CI environment!. Staying with the defaults"
- echo
+ print_info
+ print_info "This is not a CI environment!. Staying with the defaults"
Review comment:
Should we stick to the interpunction in messages? Sometimes at the end is full stop, sometimes is not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10399: Kubernetes image no embedded
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10399:
URL: https://github.com/apache/airflow/pull/10399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #10399: Kubernetes image no embedded
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #10399:
URL: https://github.com/apache/airflow/pull/10399#discussion_r472874790
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -240,9 +240,9 @@ function get_environment_for_builds_on_ci() {
export CI_BUILD_ID="0"
export CI_JOB_ID="default-job-id"
if [[ ${CI:=} != "true" ]]; then
- echo
- echo "This is not a CI environment!. Staying with the defaults"
- echo
+ print_info
+ print_info "This is not a CI environment!. Staying with the defaults"
Review comment:
Should we stick to the interpunction in messages? Sometimes at the end is full stop, sometimes doesn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #10399: Kubernetes image no embedded
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #10399:
URL: https://github.com/apache/airflow/pull/10399#discussion_r472873143
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -240,9 +240,9 @@ function get_environment_for_builds_on_ci() {
export CI_BUILD_ID="0"
export CI_JOB_ID="default-job-id"
if [[ ${CI:=} != "true" ]]; then
- echo
- echo "This is not a CI environment!. Staying with the defaults"
- echo
+ print_info
+ print_info "This is not a CI environment!. Staying with the defaults"
Review comment:
```suggestion
print_info "This is not a CI environment! Staying with the defaults"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10399: Kubernetes image no embedded
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10399:
URL: https://github.com/apache/airflow/pull/10399#issuecomment-676257021
OK. Merging this one. It has just a transient error on sqlite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #10399: Kubernetes image no embedded
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #10399:
URL: https://github.com/apache/airflow/pull/10399#discussion_r472874934
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -240,9 +240,9 @@ function get_environment_for_builds_on_ci() {
export CI_BUILD_ID="0"
export CI_JOB_ID="default-job-id"
if [[ ${CI:=} != "true" ]]; then
- echo
- echo "This is not a CI environment!. Staying with the defaults"
- echo
+ print_info
+ print_info "This is not a CI environment!. Staying with the defaults"
Review comment:
```suggestion
print_info "This is not a CI environment!. Staying with the defaults."
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on pull request #10399: Kubernetes image no embedded
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on pull request #10399:
URL: https://github.com/apache/airflow/pull/10399#issuecomment-675988581
I do not understand 99% of this but this is impressive. :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org