You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2008/03/13 16:30:42 UTC
Re: [classlib][archive] zlib performance (was: Re:
[classlib][archive] +3.25% on Eclipse startup after a bit of cleaning)
I've not tried it but I suspect that refactoring the code to use
inflateBack (rather than inflate) might also give a significant speedup.
-Mark.
On 12 March 2008 at 13:33, Mark Hindess <ma...@googlemail.com> wrote:
>
> Alexei,
>
> Your message reminded me that I had noticed that my debian packages
> for M5 - which use -Dhy.local.zlib=true - have better performance for
> inflate/deflate than the M5 releases. Given that we are unlikely to
> need to debug into the zlib code, perhaps we should *always* compile the
> zlib code with optimizations. After all it isn't really "our" code, we
> are unlikely to change it and it hasn't changed since 2005.
>
> Debian compile with -O3 and with -DUNALIGNED_OK (on x86 and x86_64) and
> my tests with minigzip show that these are reasonable choices.
>
> I would expect that this would improve eclipse startup performance.
>
> -Mark.
>
>
> On 6 March 2008 at 0:31, "Alexei Fedotov" <al...@gmail.com> wrote:
> > Dear committer,
> > I've finally got some justification that my patches for HARMONY-4569
> > are worthy to be committed, see subj. Could you please take a look?
> > Thank you in advance.
> >
> > BTW1. Volunteers are welcome to fix TODO comments cleaning the code
> > and probably getting even more speed up.
> >
> > BTW2. I just have got another idea: implementing Utf8StringHashMap
> > collection which would save space by storing a lot of English strings
> > in Utf8 byte arrays and encode/decode them during rare access
> > operations.
> >
> > On Wed, Feb 13, 2008 at 8:01 PM, Alexei Fedotov
> > <al...@gmail.com> wrote:
> > > Hello folks,
> > >
> > > Do we have original
> > > working_classlib/modules/archive/src/main/java/java/util/jar/ module
> > > contributors on board? Could anyone clarify the reasons behind heavy
> > > solution to copy manifest chunks into a separate hash table descried
> > > at HARMONY-4569? Aren't entity hash table the only object which should
> > > be populated?
> > >
> > > --
> > > With best regards,
> > > Alexei
> > >
> > > [1] http://issues.apache.org/jira/browse/HARMONY-4569
> > >
> >
> >
> >
> > --
> > With best regards,
> > Alexei
> >
>
Re: [classlib][archive] zlib performance (was: Re: [classlib][archive] +3.25% on Eclipse startup after a bit of cleaning)
Posted by Alexei Fedotov <al...@gmail.com>.
Thanks, Mark!
On Thu, Mar 13, 2008 at 6:30 PM, Mark Hindess
<ma...@googlemail.com> wrote:
>
> I've not tried it but I suspect that refactoring the code to use
> inflateBack (rather than inflate) might also give a significant speedup.
>
> -Mark.
>
>
>
> On 12 March 2008 at 13:33, Mark Hindess <ma...@googlemail.com> wrote:
> >
> > Alexei,
> >
> > Your message reminded me that I had noticed that my debian packages
> > for M5 - which use -Dhy.local.zlib=true - have better performance for
> > inflate/deflate than the M5 releases. Given that we are unlikely to
> > need to debug into the zlib code, perhaps we should *always* compile the
> > zlib code with optimizations. After all it isn't really "our" code, we
> > are unlikely to change it and it hasn't changed since 2005.
> >
> > Debian compile with -O3 and with -DUNALIGNED_OK (on x86 and x86_64) and
> > my tests with minigzip show that these are reasonable choices.
> >
> > I would expect that this would improve eclipse startup performance.
> >
> > -Mark.
> >
> >
> > On 6 March 2008 at 0:31, "Alexei Fedotov" <al...@gmail.com> wrote:
> > > Dear committer,
> > > I've finally got some justification that my patches for HARMONY-4569
> > > are worthy to be committed, see subj. Could you please take a look?
> > > Thank you in advance.
> > >
> > > BTW1. Volunteers are welcome to fix TODO comments cleaning the code
> > > and probably getting even more speed up.
> > >
> > > BTW2. I just have got another idea: implementing Utf8StringHashMap
> > > collection which would save space by storing a lot of English strings
> > > in Utf8 byte arrays and encode/decode them during rare access
> > > operations.
> > >
> > > On Wed, Feb 13, 2008 at 8:01 PM, Alexei Fedotov
> > > <al...@gmail.com> wrote:
> > > > Hello folks,
> > > >
> > > > Do we have original
> > > > working_classlib/modules/archive/src/main/java/java/util/jar/ module
> > > > contributors on board? Could anyone clarify the reasons behind heavy
> > > > solution to copy manifest chunks into a separate hash table descried
> > > > at HARMONY-4569? Aren't entity hash table the only object which should
> > > > be populated?
> > > >
> > > > --
> > > > With best regards,
> > > > Alexei
> > > >
> > > > [1] http://issues.apache.org/jira/browse/HARMONY-4569
> > > >
> > >
> > >
> > >
> > > --
> > > With best regards,
> > > Alexei
> > >
> >
>
>
>
--
With best regards,
Alexei