You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2018/02/01 20:02:42 UTC

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

Hello Michael Ho, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9164

to look at the new patch set (#2).

Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC
......................................................................

IMPALA-6448: Re-enable kerberized testing with KRPC

For the patch for IMPALA-5054, we realized that we needed to make
the kudu::rpc::Messenger configurable. A patch was done on the Kudu
side which is tracked by KUDU-2228. As part of that patch, one of
the design decisions taken was to only allow kerberos either on or
off for the entirety of the process life. This means that we cannot
switch kerberos on and off in the same process any more with KRPC.
This behavior can be found in SaslInit() in kudu/rpc/sasl_common.cc.

This affected our kerberized rpc-mgr-tests. This patch splits out
the kerberized part of rpc-mgr-test into rpc-mgr-kerberized-test.

It also puts the common code between both the files into
rpc-mgr-test-base.h

Change-Id: I6412978316de90875c98f8fbe51c8d215c227b18
---
M be/src/rpc/CMakeLists.txt
A be/src/rpc/rpc-mgr-kerberized-test.cc
A be/src/rpc/rpc-mgr-test-base.h
M be/src/rpc/rpc-mgr-test.cc
4 files changed, 364 insertions(+), 301 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/9164/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6412978316de90875c98f8fbe51c8d215c227b18
Gerrit-Change-Number: 9164
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>