You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/04 22:44:05 UTC

[GitHub] [commons-dbcp] fgdrf commented on a change in pull request #38: [DBCP-562] avoids exposing password via JMX

fgdrf commented on a change in pull request #38: [DBCP-562] avoids exposing password via JMX
URL: https://github.com/apache/commons-dbcp/pull/38#discussion_r387979387
 
 

 ##########
 File path: src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java
 ##########
 @@ -201,13 +201,6 @@ default String getDefaultSchema() {
      */
     int getNumIdle();
 
-    /**
 
 Review comment:
   @garydgregory Thanks for your fast feedback, I'll investigate if its possible to "filter" by attribute while register MBean. Since the method was public its exported. Any suggestions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services