svn commit: r1146306 - /subversion/branches/1.7.x/STATUS

[da...@apache.org]

Author: danielsh
Date: Wed Jul 13 19:44:57 2011
New Revision: 1146306

URL: http://svn.apache.org/viewvc?rev=1146306&view=rev
Log:
Nominate r1146222.

I've checked the rest of fs_fs.c, and there are no other similar problems,
assuming that apr_psprintf("%s", NULL) is safe and svn_fs_fs__id_unparse() 
isn't called on NULL id's; but I have not verified either of those
assumptions yet.

Modified:
    subversion/branches/1.7.x/STATUS

Modified: subversion/branches/1.7.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/STATUS?rev=1146306&r1=1146305&r2=1146306&view=diff
==============================================================================
--- subversion/branches/1.7.x/STATUS (original)
+++ subversion/branches/1.7.x/STATUS Wed Jul 13 19:44:57 2011
@@ -50,6 +50,14 @@ Candidate changes:
    Votes:
      +1: rhuijben
 
+ * r1146222
+   Add a NULL check in an error path.
+   Justification
+     Avoids segfaults.
+   Votes:
+     +1: danielsh
+
+
 Candidate changes for 1.7.x (post-1.7.0):
 =========================================
 

Re: svn commit: r1146306 - /subversion/branches/1.7.x/STATUS

[Greg Stein <gs...@gmail.com>]

On Wed, Jul 13, 2011 at 15:44,  <da...@apache.org> wrote:
> Author: danielsh
> Date: Wed Jul 13 19:44:57 2011
> New Revision: 1146306
>
> URL: http://svn.apache.org/viewvc?rev=1146306&view=rev
> Log:
> Nominate r1146222.
>
> I've checked the rest of fs_fs.c, and there are no other similar problems,
> assuming that apr_psprintf("%s", NULL) is safe and svn_fs_fs__id_unparse()
> isn't called on NULL id's; but I have not verified either of those
> assumptions yet.

apr/strings/apr_snprintf.c::apr_vformatter() ... look for the case
's', and note that it tests for NULL. If so, then it uses S_NULL for
the string, which is defined as "(null)".

Cheers,
-g