[GitHub] [commons-collections] Claudenw commented on pull request #398: Changes required to open testing to new implementations.

["Claudenw (via GitHub)" <gi...@apache.org>]

Claudenw commented on PR #398:
URL: https://github.com/apache/commons-collections/pull/398#issuecomment-1591756084

   > This doesn't justify why the classes need to be `public`. Are you doing development in a different package?
   
   I am.  I plan on submitting the work back and would like to discuss it.
   
   The code is a stable Bloom filter which has some different properties from a normal Bloom filter.  It is somewhat like a counting Bloom filter except that:
   
   - It counts down from a fairly low number.  A byte or smaller.
   - It automatically decrements on an insert.
   
   It is used in streaming data to detect duplicates in what is effectively a sliding window.
   
   I was thinking of submitting it in a the package org.apache.commons.collections4.bloomfilter.stable as there are several helper classes to go with the Bloom filter class itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org