[GitHub] [incubator-druid] jon-wei commented on issue #7900: Develop a new Indexer process for running ingestion tasks

[GitBox <gi...@apache.org>]

jon-wei commented on issue #7900: Develop a new Indexer process for running ingestion tasks
URL: https://github.com/apache/incubator-druid/issues/7900#issuecomment-513002129
 
 
   > When I look at it from that perspective, it seems more logical to add a configuration parameter to existing MiddleManager node type that says whether or not to run task processes in same jvm process.
   
   I found that it was cleaner to define a new node type, since there are aspects of the new process that diverge from the existing MM's behavior.
   
    For example, with lookups, MM process doesn't need to load them but the new indexer does. In `DruidNodeDiscoveryProvider`, I would otherwise have to associate the MiddleManager node type with LookupNodeService and doing that kind of control across the board with a shared node type seems complicated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org