You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/25 20:25:06 UTC

[GitHub] gaborgsomogyi edited a comment on issue #23764: [SPARK-26825][SS] Fix temp checkpoint creation in cluster mode when default filesystem is not local.

gaborgsomogyi edited a comment on issue #23764: [SPARK-26825][SS] Fix temp checkpoint creation in cluster mode when default filesystem is not local.
URL: https://github.com/apache/spark/pull/23764#issuecomment-467165178
 
 
   `Utils.createTempDir` is not required for the following reasons:
   * The separate logic is already there and works in a generic way but `Utils.createTempDir` works for local only
   * Not required to create directory 2 times
   * Shutdown hook doesn't help if the process killed with `kill -9`
   * `StreamingQueryManager` responsibility is to come up with a directory and send it to `StreamExecution`
   * `StreamExecution` responsibility is to create and delete these directories
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org