[jira] [Commented] (MESOS-954) The /__processes__ endpoint in libprocess is missing a needed lock acquisition.

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886089#comment-13886089 ] 

Benjamin Mahler commented on MESOS-954:
---------------------------------------

https://reviews.apache.org/r/17519/

> The /__processes__ endpoint in libprocess is missing a needed lock acquisition.
> -------------------------------------------------------------------------------
>
>                 Key: MESOS-954
>                 URL: https://issues.apache.org/jira/browse/MESOS-954
>             Project: Mesos
>          Issue Type: Bug
>          Components: libprocess
>            Reporter: Benjamin Mahler
>
> Looks like the processing of each event queue in __processes__ is lacking the needed lock acquisition:
> Future<Response> ProcessManager::__processes__(const Request&)
> {
>   JSON::Array array;
>   synchronized (processes) {
>     foreachvalue (const ProcessBase* process, process_manager->processes) {
>       ...  
>       
>       // XXX: This processes the event queue but does not lock process.
>       foreach (Event* event, process->events) {
>         event->visit(&visitor);
>       }
>       object.values["events"] = events;
>       array.values.push_back(object);
>     }
>   }
>   return OK(array);
> }



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)