You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/08 10:11:11 UTC
[GitHub] [arrow] kszucs opened a new pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
kszucs opened a new pull request #7678:
URL: https://github.com/apache/arrow/pull/7678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#discussion_r451442654
##########
File path: cpp/src/arrow/array/array_base.h
##########
@@ -176,7 +176,7 @@ class ARROW_EXPORT Array {
Status ValidateFull() const;
protected:
- Array() : null_bitmap_data_(NULLPTR) {}
+ Array() : data_(NULLPTR), null_bitmap_data_(NULLPTR) {}
Review comment:
I initialized as ArrayData because IsNull references `data_->offset`, and that resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#discussion_r451442654
##########
File path: cpp/src/arrow/array/array_base.h
##########
@@ -176,7 +176,7 @@ class ARROW_EXPORT Array {
Status ValidateFull() const;
protected:
- Array() : null_bitmap_data_(NULLPTR) {}
+ Array() : data_(NULLPTR), null_bitmap_data_(NULLPTR) {}
Review comment:
I initialized as ArrayData because IsNull references `data_->offset`, and that resolved - at least seemed so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#discussion_r451434095
##########
File path: cpp/src/arrow/array/array_base.h
##########
@@ -176,7 +176,7 @@ class ARROW_EXPORT Array {
Status ValidateFull() const;
protected:
- Array() : null_bitmap_data_(NULLPTR) {}
+ Array() : data_(NULLPTR), null_bitmap_data_(NULLPTR) {}
Review comment:
Yes, this change is not useful as `shared_ptr` is always initialized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#discussion_r451443722
##########
File path: cpp/src/arrow/array/array_base.h
##########
@@ -176,7 +176,7 @@ class ARROW_EXPORT Array {
Status ValidateFull() const;
protected:
- Array() : null_bitmap_data_(NULLPTR) {}
+ Array() : data_(NULLPTR), null_bitmap_data_(NULLPTR) {}
Review comment:
I don't think that would solve anything. As I said, `shared_ptr` is always initialized (to nullptr).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#discussion_r451442654
##########
File path: cpp/src/arrow/array/array_base.h
##########
@@ -176,7 +176,7 @@ class ARROW_EXPORT Array {
Status ValidateFull() const;
protected:
- Array() : null_bitmap_data_(NULLPTR) {}
+ Array() : data_(NULLPTR), null_bitmap_data_(NULLPTR) {}
Review comment:
I initialized as ArrayData because IsNull references `data_->offset`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#issuecomment-655428767
https://issues.apache.org/jira/browse/ARROW-9350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#issuecomment-655519038
Closing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#discussion_r451433719
##########
File path: cpp/src/arrow/array/array_base.h
##########
@@ -176,7 +176,7 @@ class ARROW_EXPORT Array {
Status ValidateFull() const;
protected:
- Array() : null_bitmap_data_(NULLPTR) {}
+ Array() : data_(NULLPTR), null_bitmap_data_(NULLPTR) {}
Review comment:
There are multiple `Conditional jump or move depends on uninitialised value(s)` from `Array.IsNull` and `Array.IsValid` but it doesn't seem to solve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #7678:
URL: https://github.com/apache/arrow/pull/7678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7678: ARROW-9350: [C++][CI] Nightly valgrind job failures
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7678:
URL: https://github.com/apache/arrow/pull/7678#issuecomment-655481024
Should probably close this in favor of #7679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org