You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/13 07:18:22 UTC
[kudu-CR] [gradle] remove failOnNoMatchingTests
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15428
Change subject: [gradle] remove failOnNoMatchingTests
......................................................................
[gradle] remove failOnNoMatchingTests
I found it confusing when gradle reports success on executing test
targets which don't exist. Prior to this patch, the following returned
success and claimed successfully executing tasks:
$ ./gradlew :kudu-client:test --tests org.apache.kudu.client.Nonsense
BUILD SUCCESSFUL in 1s
15 actionable tasks: 1 executed, 14 up-to-date
This patch fixes it by removing failOnNoMatchingTests.
It seems there were some ramifications on the pattern matching for
dist-test some time ago, but I verified prior and after this patch
and saw that the following works and breaks the same way:
works:
../build-support/dist_test.py java loop -n 8 '*ITClient'
../build-support/dist_test.py java loop -n 8 '*ITClient*'
../build-support/dist_test.py java loop -n 8 org/apache/kudu/client/TestConnectToCluster
doesn't work:
../build-support/dist_test.py java loop -n 8 '*ITClient.class'
../build-support/dist_test.py java loop -n 8 '*ITClient*X'
../build-support/dist_test.py java loop -n 8 org/apache/kudu/client/TestConnectToCluster.class
Change-Id: Iabb0f72fb9481c775ebcc9881a39180fb0413154
---
M java/gradle/tests.gradle
1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/15428/1
--
To view, visit http://gerrit.cloudera.org:8080/15428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabb0f72fb9481c775ebcc9881a39180fb0413154
Gerrit-Change-Number: 15428
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [gradle] remove failOnNoMatchingTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [gradle] remove failOnNoMatchingTests
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iabb0f72fb9481c775ebcc9881a39180fb0413154
Gerrit-Change-Number: 15428
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [gradle] remove failOnNoMatchingTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15428 )
Change subject: [gradle] remove failOnNoMatchingTests
......................................................................
Patch Set 1: Verified+1
unrelated dist-test snafu:
failed to download task files: WARNING 120 isolateserver(1484): Adding unknown file a335e58069b
--
To view, visit http://gerrit.cloudera.org:8080/15428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabb0f72fb9481c775ebcc9881a39180fb0413154
Gerrit-Change-Number: 15428
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 07:37:53 +0000
Gerrit-HasComments: No
[kudu-CR] [gradle] remove failOnNoMatchingTests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15428 )
Change subject: [gradle] remove failOnNoMatchingTests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabb0f72fb9481c775ebcc9881a39180fb0413154
Gerrit-Change-Number: 15428
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 12:41:56 +0000
Gerrit-HasComments: No
[kudu-CR] [gradle] remove failOnNoMatchingTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15428 )
Change subject: [gradle] remove failOnNoMatchingTests
......................................................................
[gradle] remove failOnNoMatchingTests
I found it confusing when gradle reports success on executing test
targets which don't exist. Prior to this patch, the following returned
success and claimed successfully executing tasks:
$ ./gradlew :kudu-client:test --tests org.apache.kudu.client.Nonsense
BUILD SUCCESSFUL in 1s
15 actionable tasks: 1 executed, 14 up-to-date
This patch fixes it by removing failOnNoMatchingTests.
It seems there were some ramifications on the pattern matching for
dist-test some time ago, but I verified prior and after this patch
and saw that the following works and breaks the same way:
works:
../build-support/dist_test.py java loop -n 8 '*ITClient'
../build-support/dist_test.py java loop -n 8 '*ITClient*'
../build-support/dist_test.py java loop -n 8 org/apache/kudu/client/TestConnectToCluster
doesn't work:
../build-support/dist_test.py java loop -n 8 '*ITClient.class'
../build-support/dist_test.py java loop -n 8 '*ITClient*X'
../build-support/dist_test.py java loop -n 8 org/apache/kudu/client/TestConnectToCluster.class
Change-Id: Iabb0f72fb9481c775ebcc9881a39180fb0413154
Reviewed-on: http://gerrit.cloudera.org:8080/15428
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/gradle/tests.gradle
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Alexey Serbin: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabb0f72fb9481c775ebcc9881a39180fb0413154
Gerrit-Change-Number: 15428
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)