You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li <li...@cloudera.com> on 2017/04/27 19:19:26 UTC

Review Request 58811: SENTRY-1400 [Flaky test] TestSentryWebServerWithSSL times out

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58811/
-----------------------------------------------------------

Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda, and Vamsee Yarlagadda.


Repository: sentry


Description
-------

Add log message to find out if the key store path put in configuration is the same as the one used by web server


Diffs
-----

  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae 


Diff: https://reviews.apache.org/r/58811/diff/1/


Testing
-------


Thanks,

Na Li


Re: Review Request 58811: SENTRY-1400 [Flaky test] TestSentryWebServerWithSSL times out

Posted by Na Li <li...@cloudera.com>.

> On April 28, 2017, 8:27 a.m., Alexander Kolbasov wrote:
> > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
> > Line 187 (original), 187 (patched)
> > <https://reviews.apache.org/r/58811/diff/1/?file=1702072#file1702072line188>
> >
> >     Can you clarify how does this change fixes the problem?

This does not fix anything. It just provides additional info I need to find out the root cause of this issue.


- Na


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58811/#review173295
-----------------------------------------------------------


On April 27, 2017, 7:19 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58811/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 7:19 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add log message to find out if the key store path put in configuration is the same as the one used by web server
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae 
> 
> 
> Diff: https://reviews.apache.org/r/58811/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Na Li
> 
>


Re: Review Request 58811: SENTRY-1400 [Flaky test] TestSentryWebServerWithSSL times out

Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58811/#review173295
-----------------------------------------------------------




sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
Line 187 (original), 187 (patched)
<https://reviews.apache.org/r/58811/#comment246327>

    Can you clarify how does this change fixes the problem?


- Alexander Kolbasov


On April 27, 2017, 7:19 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58811/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 7:19 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add log message to find out if the key store path put in configuration is the same as the one used by web server
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae 
> 
> 
> Diff: https://reviews.apache.org/r/58811/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Na Li
> 
>