You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/11 09:33:26 UTC
[GitHub] [superset] geido opened a new pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
geido opened a new pull request #16192:
URL: https://github.com/apache/superset/pull/16192
### SUMMARY
This PR makes the tooltip appear only when the label does not fit the container in the Dataset panel. Also, it hides the tooltip when the drag event starts.
### BEFORE
https://user-images.githubusercontent.com/60598000/129005898-a3b9a073-355d-41d2-9627-fc77f1083238.mp4
### AFTER NO DRAG AND DROP
https://user-images.githubusercontent.com/60598000/129004634-224d4f17-8a2a-4c00-9376-0b70005b6f67.mp4
### AFTER DRAG AND DROP ON
https://user-images.githubusercontent.com/60598000/129004722-337326ca-d255-4203-ae7c-f95502067803.mp4
### TESTING INSTRUCTIONS
1. Visit Explore
2. Observe the labels with long text in the Dataset panel and make sure they are truncated with ellipsis
3. Hover the labels and check the tooltip
4. Expand the panel until the text isn't truncated and hover the labels
5. Make sure the tooltip isn't appearing
6. Drag an item
7. Make sure the tooltip isn't appearing
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #15996
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16192:
URL: https://github.com/apache/superset/pull/16192#issuecomment-896695949
@rosemarie-chiu @jinghua-qa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #16192:
URL: https://github.com/apache/superset/pull/16192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16192:
URL: https://github.com/apache/superset/pull/16192#issuecomment-897835052
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16192:
URL: https://github.com/apache/superset/pull/16192#issuecomment-896685894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16192?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16192](https://codecov.io/gh/apache/superset/pull/16192?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4117407) into [master](https://codecov.io/gh/apache/superset/commit/a70248736fc97572b0d45909c37aa6cef0e9c784?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a702487) will **decrease** coverage by `0.02%`.
> The diff coverage is `67.64%`.
[](https://codecov.io/gh/apache/superset/pull/16192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16192 +/- ##
==========================================
- Coverage 76.82% 76.79% -0.03%
==========================================
Files 996 996
Lines 52962 53041 +79
Branches 6736 6773 +37
==========================================
+ Hits 40689 40735 +46
- Misses 12048 12077 +29
- Partials 225 229 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.16% <67.64%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `76.00% <54.54%> (-4.73%)` | :arrow_down: |
| [...atasourcePanel/DatasourcePanelDragOption/index.tsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ09wdGlvbi9pbmRleC50c3g=) | `94.11% <91.66%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `77.27% <0.00%> (-7.73%)` | :arrow_down: |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `74.46% <0.00%> (-1.44%)` | :arrow_down: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `63.06% <0.00%> (-1.10%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `46.98% <0.00%> (-0.83%)` | :arrow_down: |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `43.36% <0.00%> (-0.79%)` | :arrow_down: |
| [.../database/DatabaseModal/DatabaseConnectionForm.tsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0udHN4) | `53.46% <0.00%> (-0.54%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `71.63% <0.00%> (-0.32%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `72.61% <0.00%> (-0.06%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/superset/pull/16192/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16192?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16192?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a702487...4117407](https://codecov.io/gh/apache/superset/pull/16192?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16192:
URL: https://github.com/apache/superset/pull/16192#issuecomment-896698365
@geido Ephemeral environment spinning up at http://18.236.192.117:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16192:
URL: https://github.com/apache/superset/pull/16192#issuecomment-897423774
> Thanks for the improvement, this is awesome!
>
> 1. can we also add this enhancement to non-dnd? I think user can be benefit from it. There are quite a few features built upon dnd so far, can you guys help brainstorm how to apply those to all 3 modes, easily? @kgabryje @villebro
@junlincc this is already implemented with D&D off as well
> 2. towards the end of the video, after i drop the super long metric in the zone, tooltip is not attached to the field, maybe because i resize the panel early on? let's address this issue in this pr 🙏:)
This is already fixed in my other PR https://github.com/apache/superset/pull/16060
https://user-images.githubusercontent.com/60598000/129158706-f00c7927-fad5-49cc-bb02-2c5e982df218.mp4
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16192:
URL: https://github.com/apache/superset/pull/16192#issuecomment-897305549
Thanks for the improvement, this is awesome!
1. can we also add this enhancement to non-dnd? I think user can be benefit from it. There are quite a few features built upon dnd so far, can you guys help brainstorm how to apply those to all 3 modes, easily? @kgabryje @villebro
2. towards the end of the video, after i drop the super long metric in the zone, tooltip is not attached to the field, maybe because i resize the panel early on? let's address this issue in this pr 🙏:)
https://user-images.githubusercontent.com/67837651/129130547-352e010e-9393-41eb-bfd5-e82f664f87b4.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #16192:
URL: https://github.com/apache/superset/pull/16192#issuecomment-897305549
Thanks for the improvement, this is awesome!
1. can we also add this enhancement to non-dnd? I think user can be benefit from it. There are quite a few features built upon dnd so far, can you guys help brainstorm how to apply those to all 3 modes, easily? @kgabryje @villebro
2. towards the end of the video, after i drop the super long metric in the zone, tooltip is not attached to the field, maybe because i resize the panel early on? let's address this issue in this pr 🙏:)
https://user-images.githubusercontent.com/67837651/129130814-e4b1afb5-ab5d-4e31-b626-ecff1f5aac09.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16192: fix(Explore): Show the tooltip only when label does not fit the container in the Dataset panel
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16192:
URL: https://github.com/apache/superset/pull/16192#issuecomment-896696505
/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org