[jira] [Commented] (KAFKA-7869) Refactor RocksDBConfigSetter API to separate DBOptions and CFOptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843550#comment-16843550 ] 

ASF GitHub Bot commented on KAFKA-7869:
---------------------------------------

dongjinleekr commented on pull request #6766: KAFKA-7869: Refactor RocksDBConfigSetter API to separate DBOptions and CFOptions
URL: https://github.com/apache/kafka/pull/6766
 
 
   This is a draft implementation of [KAFKA-7869](https://issues.apache.org/jira/browse/KAFKA-7869). @guozhangwang Is this what you intended?
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor RocksDBConfigSetter API to separate DBOptions and CFOptions
> --------------------------------------------------------------------
>
>                 Key: KAFKA-7869
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7869
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Priority: Major
>              Labels: needs-kip, newbie
>
> Current RocksDBConfigSetter has the following API:
> {code}
> void setConfig(final String storeName, final Options options, final Map<String, Object> configs);
> {code}
> Where `Options` contains configurations for both db-level and cf-level of RocksDB.
> As we move on to have multiple CFs following KIP-258, it's better to refactor it into
> {code}
> void setConfig(final String storeName, final DBOptions dbOptions, final ColumnFamilyOptions cfOptions, final Map<String, Object> configs);
> {code}
> And then inside the internal implementation, if only the default CF is used, we can still use the other constructor of `Options` that takes both a DBOptions and CFOptions object as parameters.
> This should be started only after KIP-258 is finished.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)