[GitHub] [maven-mvnd] psiroky commented on a diff in pull request #796: Provide distributions for both maven 3.9.x and 4.0.x

["psiroky (via GitHub)" <gi...@apache.org>]

psiroky commented on code in PR #796:
URL: https://github.com/apache/maven-mvnd/pull/796#discussion_r1133755837


##########
dist-m39/src/main/provisio/maven-distro.xml:
##########
@@ -0,0 +1,93 @@
+<!--
+
+    Copyright 2019-2021 the original author or authors.
+
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+
+-->
+<assembly>
+
+    <artifactSet to="/">
+        <artifact id="org.apache.maven:apache-maven:tar.gz:bin:${maven3.version}">
+            <unpack useRoot="false"
+                    excludes="conf/logging/*,lib/maven-slf4j-provider*" />
+        </artifact>
+    </artifactSet>
+
+    <artifactSet to="/lib">
+        <artifact id="ch.qos.logback:logback-classic">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="ch.qos.logback:logback-core">
+            <exclusion id="*:*"/>
+        </artifact>
+    </artifactSet>
+
+    <artifactSet to="/lib/ext">
+        <artifact id="org.apache.maven.daemon:mvnd-daemon:${project.version}">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.apache.maven.daemon:mvnd-daemon-m39:${project.version}">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.apache.maven.daemon:mvnd-client:${project.version}">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.apache.maven.daemon:mvnd-common:${project.version}">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.apache.maven.daemon:mvnd-agent:${project.version}">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.apache.maven.daemon:mvnd-helper-agent:${project.version}">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.apache.maven.daemon:mvnd-native:${project.version}">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.codehaus.plexus:plexus-interactivity-api">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.jline:jline-terminal">
+            <exclusion id="*:*"/>
+        </artifact>
+        <artifact id="org.jline:jline-terminal-jansi">
+            <exclusion id="*:*"/>
+        </artifact>
+    </artifactSet>
+
+    <fileSet to="/">
+        <directory path="${basedir}/../dist/src/main/distro"/>
+        <directory path="${basedir}/..">
+            <include>NOTICE.txt</include>
+            <include>LICENSE.txt</include>
+            <include>README.adoc</include>
+        </directory>
+    </fileSet>
+    <fileSet to="/bin">
+        <directory path="${basedir}/../client/target">
+            <include>mvnd</include>
+            <include>mvnd.exe</include>
+        </directory>
+        <directory path="${basedir}/../dist/src/main/resources">
+            <include>platform-${os.detected.name}-${os.detected.arch}</include>
+        </directory>
+    </fileSet>
+
+    <archive name="maven-${project.version}-mvnd-mvn39-${os.detected.name}-${os.detected.arch}.zip"
+             executable="**/bin/mvnd"/>
+
+    <archive name="maven-${project.version}-mvnd-mvn39-${os.detected.name}-${os.detected.arch}.tar.gz"
+             executable="**/bin/mvnd"/>

Review Comment:
   Just thinking out loud - this produces a file named e.g. `maven-1.0.0-m5-SNAPSHOT-mvnd-mvn39-linux-amd64.tar.gz` which to _me_ sounds like this is somewhat related to Maven version `1.0.0-m5-SNAPSHOT`, which is not really the case. This is the version of the Maven daemon. Was there a specific reason to change the naming scheme compared to the older branches (e.g. `maven-mvnd-0.10.0-SNAPSHOT-linux-amd64.tar.gz`)? Would it make sense to go back to `maven-mvnd-1.0.0-m5-SNAPSHOT-mvn39-linux-amd64.tar.gz`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org