You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (Jira)" <ji...@apache.org> on 2019/09/22 20:11:00 UTC
[jira] [Commented] (HIVE-22228) SemanticAnalyzer cleanup -
visibility + types
[ https://issues.apache.org/jira/browse/HIVE-22228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935412#comment-16935412 ]
Hive QA commented on HIVE-22228:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 8s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 53s{color} | {color:blue} ql in master has 1570 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 49s{color} | {color:blue} itests/util in master has 51 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 53s{color} | {color:red} ql: The patch generated 40 new + 1889 unchanged - 269 fixed = 1929 total (was 2158) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 7s{color} | {color:red} ql generated 7 new + 1560 unchanged - 10 fixed = 1567 total (was 1570) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 15s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Possible null pointer dereference of RowSchema.signature on branch that might be infeasible in org.apache.hadoop.hive.ql.exec.RowSchema.equals(Object) Dereferenced at RowSchema.java:RowSchema.signature on branch that might be infeasible in org.apache.hadoop.hive.ql.exec.RowSchema.equals(Object) Dereferenced at RowSchema.java:[line 132] |
| | The field org.apache.hadoop.hive.ql.parse.QBJoinTree.rhsSemijoin is transient but isn't set by deserialization In QBJoinTree.java:but isn't set by deserialization In QBJoinTree.java |
| | tmp could be null and is guaranteed to be dereferenced in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genColListRegex(String, String, ASTNode, List, Set, RowResolver, RowResolver, Integer, RowResolver, List, boolean) Dereferenced at SemanticAnalyzer.java:is guaranteed to be dereferenced in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genColListRegex(String, String, ASTNode, List, Set, RowResolver, RowResolver, Integer, RowResolver, List, boolean) Dereferenced at SemanticAnalyzer.java:[line 3749] |
| | Nullcheck of tmp at line 3707 of value previously dereferenced in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genColListRegex(String, String, ASTNode, List, Set, RowResolver, RowResolver, Integer, RowResolver, List, boolean) At SemanticAnalyzer.java:3707 of value previously dereferenced in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genColListRegex(String, String, ASTNode, List, Set, RowResolver, RowResolver, Integer, RowResolver, List, boolean) At SemanticAnalyzer.java:[line 3707] |
| | Nullcheck of sampleExprs at line 11483 of value previously dereferenced in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genTablePlan(String, QB) At SemanticAnalyzer.java:11483 of value previously dereferenced in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genTablePlan(String, QB) At SemanticAnalyzer.java:[line 11483] |
| | Nullcheck of rootTasks at line 306 of value previously dereferenced in org.apache.hadoop.hive.ql.parse.TaskCompiler.compile(ParseContext, List, Set, Set) At TaskCompiler.java:306 of value previously dereferenced in org.apache.hadoop.hive.ql.parse.TaskCompiler.compile(ParseContext, List, Set, Set) At TaskCompiler.java:[line 281] |
| | Switch statement found in org.apache.hadoop.hive.ql.parse.authorization.HiveAuthorizationTaskFactoryImpl.createShowRoleGrantTask(ASTNode, Path, Set, Set) where default case is missing At HiveAuthorizationTaskFactoryImpl.java:Path, Set, Set) where default case is missing At HiveAuthorizationTaskFactoryImpl.java:[lines 94-102] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18682/dev-support/hive-personality.sh |
| git revision | master / 25f0fb4 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18682/yetus/diff-checkstyle-ql.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18682/yetus/new-findbugs-ql.html |
| modules | C: ql itests/util U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18682/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> SemanticAnalyzer cleanup - visibility + types
> ---------------------------------------------
>
> Key: HIVE-22228
> URL: https://issues.apache.org/jira/browse/HIVE-22228
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22228.01.patch
>
>
> Cleaning up SemanticAnalyzer:
> * reduce the visibility of those functions/variables that are too wide, so their scope is clearer
> * modify the type of data structures, use interface instead of actual implementation (e.g. HashMap -> Map in variable declaration)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)