You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/09 19:32:07 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #28638: Fix for LocalKubernetesExecutor scheduler is not serving logs

dstandish commented on code in PR #28638:
URL: https://github.com/apache/airflow/pull/28638#discussion_r1065031567


##########
airflow/executors/local_kubernetes_executor.py:
##########
@@ -48,6 +48,8 @@ class LocalKubernetesExecutor(LoggingMixin):
 
     is_local: bool = False
 
+    serve_logs: bool = True

Review Comment:
   i think all Celery* executors need to serve logs, so i'd assume (without having looked) that this one needs to be true (unless something weird happens and  it ends up serving anyway because of its child executor)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org