You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "tihom88 (via GitHub)" <gi...@apache.org> on 2023/06/15 17:01:27 UTC
[GitHub] [jackrabbit-oak] tihom88 opened a new pull request, #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
tihom88 opened a new pull request, #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991
…d not serialise index data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino commented on code in PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#discussion_r1233763651
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/index/ReindexIT.java:
##########
@@ -19,6 +19,7 @@
package org.apache.jackrabbit.oak.index;
+import org.apache.jackrabbit.commons.JcrUtils;
Review Comment:
unused
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
Posted by "tihom88 (via GitHub)" <gi...@apache.org>.
tihom88 commented on code in PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#discussion_r1238390508
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -121,7 +121,7 @@ public void updateIndexDefinitions(NodeBuilder rootBuilder) throws IOException,
protected void dumpIndexDefinitions(NodeStore nodeStore) throws IOException {
IndexDefinitionPrinter printer = new IndexDefinitionPrinter(nodeStore, indexHelper.getIndexPathService());
- printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\"]}");
+ printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\", \"-:data\", \"-:suggest-data\"]}");
Review Comment:
Hi @thomasmueller ,
Looks like we don't need hidden nodes at all in index-definitions file. While importing index we do cloneVisibleState from index definition.
https://github.com/apache/jackrabbit-oak/blob/16edc2c0b7a3ab20cfbc2dc04b92a5ed245941dd/oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/ReindexOperations.java#L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
Posted by "tihom88 (via GitHub)" <gi...@apache.org>.
tihom88 commented on code in PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#discussion_r1238390508
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -121,7 +121,7 @@ public void updateIndexDefinitions(NodeBuilder rootBuilder) throws IOException,
protected void dumpIndexDefinitions(NodeStore nodeStore) throws IOException {
IndexDefinitionPrinter printer = new IndexDefinitionPrinter(nodeStore, indexHelper.getIndexPathService());
- printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\"]}");
+ printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\", \"-:data\", \"-:suggest-data\"]}");
Review Comment:
Hi @thomasmueller ,
Looks like we don't need hidden nodes at all in index-definitions file. While importing index we do cloneVisibleState from index definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] tihom88 commented on pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
Posted by "tihom88 (via GitHub)" <gi...@apache.org>.
tihom88 commented on PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#issuecomment-1639692569
Testing completed on 1.22.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
Posted by "thomasmueller (via GitHub)" <gi...@apache.org>.
thomasmueller commented on code in PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#discussion_r1233796327
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -121,7 +121,7 @@ public void updateIndexDefinitions(NodeBuilder rootBuilder) throws IOException,
protected void dumpIndexDefinitions(NodeStore nodeStore) throws IOException {
IndexDefinitionPrinter printer = new IndexDefinitionPrinter(nodeStore, indexHelper.getIndexPathService());
- printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\"]}");
+ printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\", \"-:data\", \"-:suggest-data\"]}");
Review Comment:
I'm not sure if this is actually correct.
Isn't the dump needed for import? If yes, then that would mean if we don't export the ":data" node, import of an index would have to do a full reindex as the index data is empty...
So, first we need to check where this dumpIndexDefinitions method is actually called from... unluckily, there is no documentation it seems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
Posted by "tihom88 (via GitHub)" <gi...@apache.org>.
tihom88 commented on code in PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#discussion_r1234751799
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -121,7 +121,7 @@ public void updateIndexDefinitions(NodeBuilder rootBuilder) throws IOException,
protected void dumpIndexDefinitions(NodeStore nodeStore) throws IOException {
IndexDefinitionPrinter printer = new IndexDefinitionPrinter(nodeStore, indexHelper.getIndexPathService());
- printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\"]}");
+ printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\", \"-:data\", \"-:suggest-data\"]}");
Review Comment:
I tested it locally and found out that index definitions don't have :data if --index-paths are provided in command line. But it seems to have :data if --index-paths are not provided.
For :suggest-data also, found out that :suggest-data node only contained "lastUpdated" property in case --index-paths are provided. So looks like reindexing works without this info.
As :status-data is something which was part of index-definitions, I added a test case just to check if suggest data is preset with this new filter. Let me know if you think we should add few more test cases/ any specific case you think we should incorporate in current test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] reschke commented on pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#issuecomment-1639720146
1.22??? This was a merge to "trunk", no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] tihom88 merged pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…
Posted by "tihom88 (via GitHub)" <gi...@apache.org>.
tihom88 merged PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org