You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/08/14 21:16:40 UTC
[PR] fix(users): show password validation errors [superset]
aminghadersohi opened a new pull request, #43191:
URL: https://github.com/apache/superset/pull/43191
### SUMMARY
Surface field-level validation messages returned by the user API for HTTP 400 responses. Flask-AppBuilder uses 400 for Marshmallow validation errors such as password-complexity failures, while duplicate username/email database errors remain 422 and retain their existing friendly messages.
This keeps the API's established status-code contract intact rather than changing a shared Flask-AppBuilder endpoint. Client-side password-complexity checks are intentionally not duplicated because minimum length and blocklists are operator-configurable server policy.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:** Submitting a password shorter than the configured minimum showed the generic red toast: “There was an error creating the user. Please, try again.”
**After:** The same submission shows the server-provided reason in the red toast: “Password must be at least 8 characters long.” (The number follows the server's configured policy.)
### TESTING INSTRUCTIONS
1. Open **Settings → List Users → + User** as an administrator.
2. Complete the required fields and submit matching passwords shorter than the configured minimum.
3. Confirm the toast displays the specific minimum-length validation message and the user is not created.
4. Try creating a user with an existing username and confirm the existing friendly duplicate-username toast remains unchanged.
Automated test:
```bash
cd superset-frontend
npm run test -- src/features/users/UserListModal.test.tsx --runInBand
```
The focused Jest suite passes (2 tests). Pre-commit formatting, linting, custom rules, and style checks pass. The targeted type-check hook cannot complete in this fresh worktree because generated `packages/*/lib` declarations have not been built; its reported errors are in unrelated existing files.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43191:
URL: https://github.com/apache/superset/pull/43191#issuecomment-5298256157
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43191:
URL: https://github.com/apache/superset/pull/43191#issuecomment-5332580048
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 4f9035793a69b924f5751898cdd6e61241a53df9 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a84a81ea182d20008bd953d |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43191--superset-docs-preview.netlify.app](https://deploy-preview-43191--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctLDsIwDAXAu3hNRFo-CtyAY7xii0Rq48huqRDi7mQ3m_lSM13aSneiA02G-szdWEp9ZbCYay5Hz7qHzcVCg_uuxuGNuTDWojWImVrfLG3Wz4P7vyKdkQbBkEYeY4xp4tvlxPT7Aw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43191--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43191:
URL: https://github.com/apache/superset/pull/43191#issuecomment-5334460881
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43191:
URL: https://github.com/apache/superset/pull/43191#issuecomment-5298393291
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43191?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.19048%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.65%. Comparing base ([`f458721`](https://app.codecov.io/gh/apache/superset/commit/f4587218dd19d046c3e4d00063e7d27f8a2ed354?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ae37652`](https://app.codecov.io/gh/apache/superset/commit/ae376521f07c474d88e235d235c073ef2e052bed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43191?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset-frontend/src/features/users/utils.ts](https://app.codecov.io/gh/apache/superset/pull/43191?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Ffeatures%2Fusers%2Futils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL3VzZXJzL3V0aWxzLnRz) | 84.21% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rset-frontend/src/features/users/UserListModal.tsx](https://app.codecov.io/gh/apache/superset/pull/43191?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Ffeatures%2Fusers%2FUserListModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL3VzZXJzL1VzZXJMaXN0TW9kYWwudHN4) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43191 +/- ##
=======================================
Coverage 66.64% 66.65%
=======================================
Files 2873 2873
Lines 163625 163629 +4
Branches 37767 37769 +2
=======================================
+ Hits 109053 109069 +16
+ Misses 52442 52430 -12
Partials 2130 2130
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43191/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.77% <76.19%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43191?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on code in PR #43191:
URL: https://github.com/apache/superset/pull/43191#discussion_r3806943056
##########
superset-frontend/src/features/users/utils.ts:
##########
@@ -17,10 +17,49 @@
* under the License.
*/
import { t } from '@apache-superset/core/translation';
-import { SupersetClient } from '@superset-ui/core';
+import { getClientErrorObject, SupersetClient } from '@superset-ui/core';
import { SelectOption } from 'src/components/ListView';
+import { Actions } from 'src/constants';
import { FormValues } from './types';
+type AddDangerToast = (message: string) => void;
+
+export const handleUserError = async (
+ err: Response,
+ action: Actions.CREATE | Actions.UPDATE,
+ addDangerToast: AddDangerToast,
+): Promise<never> => {
+ let errorMessage =
+ action === Actions.CREATE
+ ? t('There was an error creating the user. Please, try again.')
+ : t('There was an error updating the user. Please, try again.');
+
+ if (err.status === 400 || err.status === 422) {
+ const errorData = await getClientErrorObject(err);
+ const message: unknown = errorData.message;
+
+ if (err.status === 400 && message && typeof message === 'object') {
Review Comment:
Good catch — relaxed to `err.status === 400 && message`, plus an `errorData.error` truthiness check so a JSON 400 with no usable message still falls back to the generic toast. Added a test covering the plain-string shape (`User must have at least one role or group!`), and the non-JSON test still passes.
##########
superset-frontend/src/features/users/utils.ts:
##########
@@ -17,10 +17,49 @@
* under the License.
*/
import { t } from '@apache-superset/core/translation';
-import { SupersetClient } from '@superset-ui/core';
+import { getClientErrorObject, SupersetClient } from '@superset-ui/core';
import { SelectOption } from 'src/components/ListView';
+import { Actions } from 'src/constants';
import { FormValues } from './types';
+type AddDangerToast = (message: string) => void;
+
+export const handleUserError = async (
+ err: Response,
+ action: Actions.CREATE | Actions.UPDATE,
+ addDangerToast: AddDangerToast,
+): Promise<never> => {
+ let errorMessage =
+ action === Actions.CREATE
+ ? t('There was an error creating the user. Please, try again.')
+ : t('There was an error updating the user. Please, try again.');
+
+ if (err.status === 400 || err.status === 422) {
+ const errorData = await getClientErrorObject(err);
+ const message: unknown = errorData.message;
+
+ if (err.status === 400 && message && typeof message === 'object') {
+ errorMessage = errorData.error;
+ } else if (
+ err.status === 422 &&
+ errorData.error.includes('duplicate key value')
Review Comment:
Done — `errorData.error?.includes(...)`, so an undefined `error` can no longer throw before `addDangerToast`. Added a test for a JSON 422 body with neither `message` nor `errors` that asserts the generic toast fires.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on code in PR #43191:
URL: https://github.com/apache/superset/pull/43191#discussion_r3806865188
##########
superset-frontend/src/features/users/utils.ts:
##########
@@ -17,10 +17,49 @@
* under the License.
*/
import { t } from '@apache-superset/core/translation';
-import { SupersetClient } from '@superset-ui/core';
+import { getClientErrorObject, SupersetClient } from '@superset-ui/core';
import { SelectOption } from 'src/components/ListView';
+import { Actions } from 'src/constants';
import { FormValues } from './types';
+type AddDangerToast = (message: string) => void;
+
+export const handleUserError = async (
+ err: Response,
+ action: Actions.CREATE | Actions.UPDATE,
+ addDangerToast: AddDangerToast,
+): Promise<never> => {
+ let errorMessage =
+ action === Actions.CREATE
+ ? t('There was an error creating the user. Please, try again.')
+ : t('There was an error updating the user. Please, try again.');
+
+ if (err.status === 400 || err.status === 422) {
+ const errorData = await getClientErrorObject(err);
+ const message: unknown = errorData.message;
+
+ if (err.status === 400 && message && typeof message === 'object') {
Review Comment:
Just a small NIT, not a blocker: this branch only fires when `message` is an object, but the user PUT endpoint also returns 400s with a plain string message. I verified on this branch that `PUT /api/v1/security/users/<pk>` with `{"roles": [], "groups": []}` returns `400 {"message": "User must have at least one role or group!"}`, which still falls through to the generic toast. Since `parseErrorJson` already copies a string `message` into `.error`, relaxing this to `if (err.status === 400 && message)` would surface both shapes, and your non-JSON test still passes because `message` is undefined in that case. Admittedly the client-side `atLeastOneRoleOrGroup` validator makes this hard to hit from the modal, so feel free to leave it as is.
##########
superset-frontend/src/features/users/utils.ts:
##########
@@ -17,10 +17,49 @@
* under the License.
*/
import { t } from '@apache-superset/core/translation';
-import { SupersetClient } from '@superset-ui/core';
+import { getClientErrorObject, SupersetClient } from '@superset-ui/core';
import { SelectOption } from 'src/components/ListView';
+import { Actions } from 'src/constants';
import { FormValues } from './types';
+type AddDangerToast = (message: string) => void;
+
+export const handleUserError = async (
+ err: Response,
+ action: Actions.CREATE | Actions.UPDATE,
+ addDangerToast: AddDangerToast,
+): Promise<never> => {
+ let errorMessage =
+ action === Actions.CREATE
+ ? t('There was an error creating the user. Please, try again.')
+ : t('There was an error updating the user. Please, try again.');
+
+ if (err.status === 400 || err.status === 422) {
+ const errorData = await getClientErrorObject(err);
+ const message: unknown = errorData.message;
+
+ if (err.status === 400 && message && typeof message === 'object') {
+ errorMessage = errorData.error;
+ } else if (
+ err.status === 422 &&
+ errorData.error.includes('duplicate key value')
Review Comment:
Another small one: `errorData.error` is typed `string` but `parseErrorJson` can return it as `undefined` for a JSON 422 body that has neither `message` nor `errors`, and the `TypeError` here would fire before `addDangerToast`, leaving the user with no toast at all. None of the current backend paths can produce that (the only 422 from this endpoint is `response_422(message=str(e.orig))`, always a string), but `errorData.error?.includes('duplicate key value')` is cheap insurance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43191:
URL: https://github.com/apache/superset/pull/43191#issuecomment-5299497814
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi merged PR #43191:
URL: https://github.com/apache/superset/pull/43191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(users): show password validation errors [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #43191:
URL: https://github.com/apache/superset/pull/43191#issuecomment-5332555131
Thanks for the thorough review @gabotorresruiz! Both nits addressed in 4f90357:
- The 400 branch now fires on any truthy `message` (object or plain string), so `PUT /api/v1/security/users/<pk>` returning `{"message": "User must have at least one role or group!"}` surfaces the server text instead of the generic toast.
- `errorData.error?.includes('duplicate key value')` guards the 422 path so a JSON body with neither `message` nor `errors` can no longer throw before `addDangerToast`.
Two tests added for those shapes; the users suite passes (5/5). Left `GroupListModal.tsx` alone for a follow-up as suggested — happy to file it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org