You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2012/07/20 08:05:39 UTC

Review Request: ec2-register: need better error handling for negative cases.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6059/
-----------------------------------------------------------

Review request for cloudstack and Prachi Damle.


Description
-------

The negative cases for which the error handling is improved, 
1. run ec2-register with incorrect field separator for architecture parameter.
2. run ec2-register without providing required parameters.


This addresses bug CS-15145.


Diffs
-----

  awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 5f45847 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2RegisterImage.java 3fd36ba 

Diff: https://reviews.apache.org/r/6059/diff/


Testing
-------


Thanks,

Likitha Shetty

Re: Review Request: ec2-register: need better error handling for negative cases.

Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6059/#review9376
-----------------------------------------------------------

Ship it!


Looks fine

- Prachi Damle


On July 20, 2012, 6:05 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6059/
> -----------------------------------------------------------
> 
> (Updated July 20, 2012, 6:05 a.m.)
> 
> 
> Review request for cloudstack and Prachi Damle.
> 
> 
> Description
> -------
> 
> The negative cases for which the error handling is improved, 
> 1. run ec2-register with incorrect field separator for architecture parameter.
> 2. run ec2-register without providing required parameters.
> 
> 
> This addresses bug CS-15145.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 5f45847 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2RegisterImage.java 3fd36ba 
> 
> Diff: https://reviews.apache.org/r/6059/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>