You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "hlteoh37 (via GitHub)" <gi...@apache.org> on 2024/11/12 18:32:45 UTC
[PR] [FLINK-36595][docs] Explicitly set connector compatibility as string … [flink-connector-opensearch]
hlteoh37 opened a new pull request, #49:
URL: https://github.com/apache/flink-connector-opensearch/pull/49
…to prevent version comparison mismatch
## Purpose of the change
* Set version as string to prevent version comparison mismatch. Issue has happened for other connectors too : https://github.com/apache/flink-connector-kafka/pull/132
* Add supported version for `flink-connector-opensearch` for v1.18 and 1.19.
* Verified artifacts available on maven: https://mvnrepository.com/artifact/org.apache.flink/flink-connector-opensearch.
* Also release note: https://lists.apache.org/thread/v9gxnflhhsr92sf76rt58ob688nnr6mj
## Significant changes
*(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)*
- [ ] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ ] New feature has been introduced
- If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36595][docs] Explicitly set connector compatibility as string … [flink-connector-opensearch]
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on PR #49:
URL: https://github.com/apache/flink-connector-opensearch/pull/49#issuecomment-2471286885
@snuyanzin it would be good to get your validation on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36595][docs] Explicitly set connector compatibility as string … [flink-connector-opensearch]
Posted by "nicusX (via GitHub)" <gi...@apache.org>.
nicusX commented on code in PR #49:
URL: https://github.com/apache/flink-connector-opensearch/pull/49#discussion_r1838605009
##########
docs/data/opensearch.yml:
##########
@@ -17,6 +17,7 @@
################################################################################
version: 2.0.0-SNAPSHOT
Review Comment:
Is this version correct?
In the `v1.2` branch the version is `1.2-SNAPSHOT`
https://github.com/apache/flink-connector-opensearch/blob/419632cc58cb81cbba47a9094576cb1a6a95978d/pom.xml#L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36595][docs] Explicitly set connector compatibility as string … [flink-connector-opensearch]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #49:
URL: https://github.com/apache/flink-connector-opensearch/pull/49#issuecomment-2471281165
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org