You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tamaya.apache.org by pl...@apache.org on 2015/01/21 02:03:28 UTC
incubator-tamaya git commit: Input of the BooleanConverter is now
trimmed as all other converters do it. Futhermore is is ensured to be
non-null.
Repository: incubator-tamaya
Updated Branches:
refs/heads/master 2ce460db0 -> 5b0aebc9a
Input of the BooleanConverter is now trimmed as all other converters do it. Futhermore is is ensured to be non-null.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/5b0aebc9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/5b0aebc9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/5b0aebc9
Branch: refs/heads/master
Commit: 5b0aebc9a0cd505dd688d0abea1fa72328b3aa74
Parents: 2ce460d
Author: Oliver B. Fischer <pl...@apache.org>
Authored: Wed Jan 21 02:02:37 2015 +0100
Committer: Oliver B. Fischer <pl...@apache.org>
Committed: Wed Jan 21 02:02:37 2015 +0100
----------------------------------------------------------------------
.../tamaya/core/internal/converters/BooleanConverter.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/5b0aebc9/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
----------------------------------------------------------------------
diff --git a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
index b309631..9eeda1b 100644
--- a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
+++ b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
@@ -21,6 +21,7 @@ package org.apache.tamaya.core.internal.converters;
import org.apache.tamaya.spi.PropertyConverter;
import java.util.Locale;
+import java.util.Objects;
import java.util.logging.Logger;
/**
@@ -32,7 +33,10 @@ public class BooleanConverter implements PropertyConverter<Boolean> {
@Override
public Boolean convert(String value) {
- String ignoreCaseValue = value.toLowerCase(Locale.ENGLISH);
+ String ignoreCaseValue = Objects.requireNonNull(value)
+ .trim()
+ .toLowerCase(Locale.ENGLISH);
+
switch(ignoreCaseValue) {
case "yes":
case "y":