You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/12 13:12:56 UTC
[GitHub] [incubator-apisix] sshniro opened a new pull request #1236: Adding
warning message when running APISIX in root path
sshniro opened a new pull request #1236: Adding warning message when running APISIX in root path
URL: https://github.com/apache/incubator-apisix/pull/1236
Duplicate of #1201 and fix for #1196.
Based on the discussion on #1201, the PR only prints the warning message to the user and does not add the root configs to the nginx config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1236: Adding warning message when running APISIX in root path
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1236: Adding warning message when running APISIX in root path
URL: https://github.com/apache/incubator-apisix/pull/1236#discussion_r392630774
##########
File path: bin/apisix
##########
@@ -41,13 +41,18 @@ local pkg_path = apisix_home .. "/deps/share/lua/5.1/apisix/lua/?.lua;"
.. apisix_home .. "/deps/share/lua/5.1/?.lua;;"
-- only for developer, use current folder as working space
+local is_root_path = false
local script_path = arg[0]
if script_path:sub(1, 2) == './' then
apisix_home = trim(excute_cmd("pwd"))
if not apisix_home then
error("failed to fetch current path")
end
+ if string.match(apisix_home, '^/[root][^/]+') then
Review comment:
we should use `string.find`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] sshniro removed a comment on issue #1236: Adding
warning message when running APISIX in root path
Posted by GitBox <gi...@apache.org>.
sshniro removed a comment on issue #1236: Adding warning message when running APISIX in root path
URL: https://github.com/apache/incubator-apisix/pull/1236#issuecomment-598197675
The test case in failing with the following error. For Linux openresty image.
```
t/node/invalid-service.t ............... 7/?
# Failed test 'TEST 3: set valid service(id: 1) - grep_error_log_out (req 0)'
# at /home/travis/build/sshniro/incubator-apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1146.
# ''
# doesn't match '(?^:invalid item data of \[/apisix/services/1\], val: mexxxxxxxxxxxxxxx, it shoud be a object)'
t/node/invalid-service.t ............... 10/? # Looks like you failed 1 test of 12.
t/node/invalid-service.t ............... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/12 subtests
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming merged pull request #1236: Adding
warning message when running APISIX in root path
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1236: Adding warning message when running APISIX in root path
URL: https://github.com/apache/incubator-apisix/pull/1236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] sshniro commented on issue #1236: Adding warning
message when running APISIX in root path
Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #1236: Adding warning message when running APISIX in root path
URL: https://github.com/apache/incubator-apisix/pull/1236#issuecomment-598197675
The test case in failing with the following error. For Linux openresty image.
```
t/node/invalid-service.t ............... 7/?
# Failed test 'TEST 3: set valid service(id: 1) - grep_error_log_out (req 0)'
# at /home/travis/build/sshniro/incubator-apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1146.
# ''
# doesn't match '(?^:invalid item data of \[/apisix/services/1\], val: mexxxxxxxxxxxxxxx, it shoud be a object)'
t/node/invalid-service.t ............... 10/? # Looks like you failed 1 test of 12.
t/node/invalid-service.t ............... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/12 subtests
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services