You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/10 00:06:18 UTC

[GitHub] [arrow] augustoasilva commented on a change in pull request #11053: ARROW-13829: [C++][Gandiva] Implement GREATEST and LEAST Hive functions on Gandiva

augustoasilva commented on a change in pull request #11053:
URL: https://github.com/apache/arrow/pull/11053#discussion_r705802067



##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##########
@@ -101,6 +101,34 @@ TEST(TestArithmeticOps, TestDiv) {
   context.Reset();
 }
 
+TEST(TestArithmeticOps, TestGreatestLeast) {
+  // Comparable functions - Greatest and Least
+  EXPECT_EQ(greatest_int32_int32(1, 2), 2);

Review comment:
       I added the types int64, float32 and float64 to the unit tests




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org