[jira] [Work logged] (BEAM-2762) Coverage report for Python code

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-2762?focusedWorklogId=467491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467491 ]

ASF GitHub Bot logged work on BEAM-2762:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Aug/20 18:34
            Start Date: 06/Aug/20 18:34
    Worklog Time Spent: 10m 
      Work Description: udim commented on a change in pull request #12257:
URL: https://github.com/apache/beam/pull/12257#discussion_r466608830



##########
File path: sdks/python/test-suites/tox/common.gradle
##########
@@ -27,6 +27,13 @@ test.dependsOn "testPy${pythonVersionSuffix}Cloud"
 toxTask "testPy${pythonVersionSuffix}Cython", "py${pythonVersionSuffix}-cython"
 test.dependsOn "testPy${pythonVersionSuffix}Cython"
 
+toxTask "testPy38CloudCoverage", "py38-cloudcoverage"
+test.dependsOn "testPy38CloudCoverage"
+
 project.task("preCommitPy${pythonVersionSuffix}") {
-      dependsOn = ["testPy${pythonVersionSuffix}Cloud", "testPy${pythonVersionSuffix}Cython"]
+      if (pythonVersionSuffix.equals('38')) {

Review comment:
       Cool!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 467491)
    Time Spent: 1h 50m  (was: 1h 40m)

> Coverage report for Python code
> -------------------------------
>
>                 Key: BEAM-2762
>                 URL: https://issues.apache.org/jira/browse/BEAM-2762
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-py-core, testing
>            Reporter: Mark Liu
>            Priority: P2
>              Labels: beam-fixit
>             Fix For: Not applicable
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> It's good to have code coverage in Python SDK to show the test coverage. Java is using jacoco-maven-plugin to generate coverage report and coveralls service to manage/display data. 
> Python have similar tool called coverage.py for report generation and coveralls-python to send report to api of coveralls service. 
> It's nice to have one place (like coveralls service) to manage and show data from different SDKs together/separately. However, there are still some problems due to the fact of Beam CI system and multi languages in Beam. The coveralls service doesn't have a good way to collect data separately from different projects. But the postcommit builds are separated by sdks. 
> As the first step, I think it's good to have the python coverage report printout in the build to give people a idea of the current coverage status at lease.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)