[GitHub] [spark] beliefer commented on issue #26204: [SPARK-29548][Core] Redirect system print stream to log4j and improve robustness

[GitBox <gi...@apache.org>]

beliefer commented on issue #26204: [SPARK-29548][Core] Redirect system print stream to log4j and improve robustness
URL: https://github.com/apache/spark/pull/26204#issuecomment-545716398
 
 
   > This does change the behavior; I'm not sure what you mean that it restores a default?
   
   My previous description is somewhat ambiguous. Let me explain again.
   `org.apache.spark.deploy.yarn.Client.createContainerLaunchContext` exists the code as below:
   ```
       // Command for the ApplicationMaster
       val commands = prefixEnv ++
         Seq(Environment.JAVA_HOME.$$() + "/bin/java", "-server") ++
         javaOpts ++ amArgs ++
         Seq(
           "1>", ApplicationConstants.LOG_DIR_EXPANSION_VAR + "/stdout",
           "2>", ApplicationConstants.LOG_DIR_EXPANSION_VAR + "/stderr")
   ```
   This code redirect the output of console to disk file.
   If the user uses a lot of `System.out` or `System.err`, it will lead to `stdout` or `stderr` is too large.
   In my production environment, it causes the disk to be full and let [NodeManager] works not fine.
   This PR redirect `System.out` or `System.err` to log4j and easy to split log.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org