You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2020/04/10 23:54:49 UTC

[GitHub] [plc4x-build-tools] splatch opened a new pull request #3: [WIP] PLC4X-193 Support for little endian types in build tools.

splatch opened a new pull request #3: [WIP] PLC4X-193 Support for little endian types in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3
 
 
   This is work in progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [plc4x-build-tools] chrisdutz commented on issue #3: [WIP] PLC4X-193 Support for little endian types in build tools.

Posted by GitBox <gi...@apache.org>.
chrisdutz commented on issue #3: [WIP] PLC4X-193 Support for little endian types in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3#issuecomment-613245404
 
 
   Hi Lukasz ... well this protocol level switch is already there ... if you initialize the Read and WriteBuffers as BE or LE.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [plc4x-build-tools] splatch commented on issue #3: [WIP] PLC4X-193 Support for little endian types in build tools.

Posted by GitBox <gi...@apache.org>.
splatch commented on issue #3: [WIP] PLC4X-193 Support for little endian types in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3#issuecomment-613112539
 
 
   @chrisdutz I didn't do any grouping cause `Protocol` itself doesn't have any marks which indicate its byte order. Stage which I committed was intended to get basic handling of fields. Now when I'm working with whole types (ie. `State`/`StateIO` in amsads) it makes a sense to introduce a protocol level switch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services