[jira] [Commented] (PARQUET-1148) [C++] Code coverage has been broken since June 23

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581398#comment-16581398 ] 

ASF GitHub Bot commented on PARQUET-1148:
-----------------------------------------

wesm closed pull request #415: PARQUET-1148: Revert coverage changes from PARQUET-1038
URL: https://github.com/apache/parquet-cpp/pull/415
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ci/upload_coverage.sh b/ci/upload_coverage.sh
index 73b37c26..81e7565b 100755
--- a/ci/upload_coverage.sh
+++ b/ci/upload_coverage.sh
@@ -26,19 +26,11 @@ ls -l
 
 echo $PARQUET_ROOT
 
-coveralls --gcov $(which gcov-4.9) \
-    --gcov-options '\-l' --root '' \
-    --include $PARQUET_ROOT \
-    --exclude $PARQUET_ROOT/parquet-build/thirdparty \
-    --exclude $PARQUET_ROOT/parquet-build/arrow_ep \
-    --exclude $PARQUET_ROOT/parquet-build/brotli_ep \
-    --exclude $PARQUET_ROOT/parquet-build/brotli_ep-prefix \
-    --exclude $PARQUET_ROOT/parquet-build/gbenchmark_ep \
-    --exclude $PARQUET_ROOT/parquet-build/googletest_ep-prefix \
-    --exclude $PARQUET_ROOT/parquet-build/snappy_ep \
-    --exclude $PARQUET_ROOT/parquet-build/snappy_ep-prefix \
-    --exclude $PARQUET_ROOT/parquet-build/zlib_ep \
-    --exclude $PARQUET_ROOT/parquet-build/zlib_ep-prefix \
-    --exclude $PARQUET_ROOT/build \
-    --exclude $PARQUET_ROOT/src/parquet/thrift \
-    --exclude /usr
+coveralls --gcov 'gcov-4.9' --gcov-options '\-lp' \
+          -r $PARQUET_ROOT \
+          -i '/src' \
+          -i '$PARQUET_ROOT/src' \
+          -e '/parquet-build' \
+          -e '$PARQUET_ROOT/parquet-build' \
+          -e '/usr' \
+          -e '$PARQUET_ROOT/src/parquet/thrift'


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [C++] Code coverage has been broken since June 23
> -------------------------------------------------
>
>                 Key: PARQUET-1148
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1148
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: cpp-1.5.0
>
>
> PR #357 is the smoking gun, but we'll need to investigate



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)