You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/22 09:16:30 UTC

[GitHub] janpio commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

janpio commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-423729731
 
 
   Awesome.
   
   So what you want to do is create a Pull Request (PR) from a branch in a fork of this repository where you changed those files.
   
   Small glossary:
   - Pull Request = Like an issue, but has code attached to it that can simply be merged into the original repository
   - Branch = A "branch" in a repository with some changes. There mostly is a `master` branch that has the main code, and many other branches with slight modifications. That way you can have a branch for each bug, feature etc. and it is easy to see only the changes for that
   - Fork = Copy of a repository under your username. At first a fork is just a copy, but then you can make changes in there (you can't do that here because you don't have access) and send a PR with those changes later.
   
   Now some links with instructions what you have to do:
   1. Fork the repo: https://help.github.com/articles/fork-a-repo/ Really relevant is just this bit: https://help.github.com/articles/fork-a-repo/#fork-an-example-repository
   2. Make changes in your repository: Now you can check out your fork with Git to your computer, change the files and commit and push the changes: https://help.github.com/articles/cloning-a-repository/ + https://help.github.com/articles/adding-a-file-to-a-repository-using-the-command-line/
   Or you can do it online on Github.com in the UI: https://help.github.com/articles/editing-files-in-your-repository/
   3. When you have edited both files in your fork, you can create a pull request on this repository to get your changes back here: https://help.github.com/articles/creating-a-pull-request/
   4. Then we have a Pull Request here with your changes that we can look at.
   
   This seems like _a lot_ now, but it is just a few simple steps once you understood it. Let me know if you hit any stumbling blocks, I'll be happy to help you along the way.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org