You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2014/10/24 16:54:40 UTC
Review Request 27140: AMBARI-7851 - HCatalog and WebHCat components in
HDPWIN should be part of Hive service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27140/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-7851
https://issues.apache.org/jira/browse/AMBARI-7851
Repository: ambari
Description
-------
AMBARI-7851 - HCatalog and WebHCat components in HDPWIN should be part of Hive service
Diffs
-----
ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json 549b6c7
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/hive-site.xml 01be0a3
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/webhcat-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/metainfo.xml bd9c8e4
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/files/templetonSmoke.sh PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/params.py a91b82c
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/service_check.py 8d8a9f2
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/service_mapping.py 5ab9742
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat_service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/templates/webhcat-env.sh.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/configuration/webhcat-site.xml bae9712
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/metainfo.xml 390dc9a
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/files/templetonSmoke.sh 2d07b8b
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/params.py 607d05d
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/service_check.py 804c8b2
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/service_mapping.py 172886c
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/webhcat.py 032ca79
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/webhcat_server.py 527efb8
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/templates/webhcat-env.sh.j2 220f420
ambari-web/app/controllers/wizard/step5_controller.js 6fb9ab1
Diff: https://reviews.apache.org/r/27140/diff/
Testing
-------
Thanks,
Artem Baranchuk
Re: Review Request 27140: AMBARI-7851 - HCatalog and WebHCat
components in HDPWIN should be part of Hive service
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27140/#review58316
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Oct. 24, 2014, 2:54 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27140/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 2:54 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7851
> https://issues.apache.org/jira/browse/AMBARI-7851
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-7851 - HCatalog and WebHCat components in HDPWIN should be part of Hive service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json 549b6c7
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/hive-site.xml 01be0a3
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/webhcat-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/metainfo.xml bd9c8e4
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/files/templetonSmoke.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/params.py a91b82c
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/service_check.py 8d8a9f2
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/service_mapping.py 5ab9742
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat_service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/templates/webhcat-env.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/configuration/webhcat-site.xml bae9712
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/metainfo.xml 390dc9a
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/files/templetonSmoke.sh 2d07b8b
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/params.py 607d05d
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/service_check.py 804c8b2
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/service_mapping.py 172886c
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/webhcat.py 032ca79
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/webhcat_server.py 527efb8
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/templates/webhcat-env.sh.j2 220f420
> ambari-web/app/controllers/wizard/step5_controller.js 6fb9ab1
>
> Diff: https://reviews.apache.org/r/27140/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 27140: AMBARI-7851 - HCatalog and WebHCat
components in HDPWIN should be part of Hive service
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27140/#review58466
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/webhcat-site.xml
<https://reviews.apache.org/r/27140/#comment99494>
I believe all *-site.xml files need supports_final="true"
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/webhcat-site.xml
<https://reviews.apache.org/r/27140/#comment99483>
typo in "hive-webhca.jar"
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/webhcat-site.xml
<https://reviews.apache.org/r/27140/#comment99485>
Is this supposed to be forward slashes instead of backslashes?
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/files/templetonSmoke.sh
<https://reviews.apache.org/r/27140/#comment99493>
hadoop fs is deprecated, use hdfs dfs instead
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat.py
<https://reviews.apache.org/r/27140/#comment99487>
This needs some community agreement, but it's generally better to only import the modules needed instead of import *
- Alejandro Fernandez
On Oct. 24, 2014, 2:54 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27140/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 2:54 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7851
> https://issues.apache.org/jira/browse/AMBARI-7851
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-7851 - HCatalog and WebHCat components in HDPWIN should be part of Hive service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json 549b6c7
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/hive-site.xml 01be0a3
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/webhcat-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/metainfo.xml bd9c8e4
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/files/templetonSmoke.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/params.py a91b82c
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/service_check.py 8d8a9f2
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/service_mapping.py 5ab9742
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/scripts/webhcat_service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/package/templates/webhcat-env.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/configuration/webhcat-site.xml bae9712
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/metainfo.xml 390dc9a
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/files/templetonSmoke.sh 2d07b8b
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/params.py 607d05d
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/service_check.py 804c8b2
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/service_mapping.py 172886c
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/webhcat.py 032ca79
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/scripts/webhcat_server.py 527efb8
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/WEBHCAT/package/templates/webhcat-env.sh.j2 220f420
> ambari-web/app/controllers/wizard/step5_controller.js 6fb9ab1
>
> Diff: https://reviews.apache.org/r/27140/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Artem Baranchuk
>
>