You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/15 00:29:39 UTC

[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error

stu01509 commented on a change in pull request #1591:
URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593988141



##########
File path: web/package.json
##########
@@ -29,9 +29,9 @@
     "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev",
     "test:component": "umi test ./src/components",
     "tsc": "tsc",
-    "cypress:open": "CYPRESS_SERVE_ENV=test cypress open",
-    "cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open",
-    "cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run"
+    "cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open",

Review comment:
       But If we don't use the `cross-env` to set the env variables, the cypress definitely will fail to start.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org