You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/05 05:59:42 UTC
[GitHub] [logging-log4j2] arturobernalg opened a new pull request #511: Use Standard Charset object (StandardCharsets)
arturobernalg opened a new pull request #511:
URL: https://github.com/apache/logging-log4j2/pull/511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on a change in pull request #511: LOG4J2-3109 - Use Standard Charset object (StandardCharsets)
Posted by GitBox <gi...@apache.org>.
vy commented on a change in pull request #511:
URL: https://github.com/apache/logging-log4j2/pull/511#discussion_r658051704
##########
File path: log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/StringEncodingBenchmark.java
##########
@@ -52,11 +53,11 @@
private static final String STRING_ISO8859_1 = "ISO-8859-1";
private static final String STRING_US_ASCII = "US-ASCII";
Review comment:
Would you mind replacing these too, please? That is, `StandardCharsets.ISO_8859_1.name()`. Otherwise the new usage seems inconsistent to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org