You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ludatabricks <gi...@git.apache.org> on 2018/05/15 17:50:39 UTC

[GitHub] spark pull request #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for...

GitHub user ludatabricks opened a pull request:

    https://github.com/apache/spark/pull/21335

    [SPARK-24231][PYSPARK][ML]  Provide Python API for evaluateEachIteration for spark.ml GBTs

    ## What changes were proposed in this pull request?
    
    Add evaluateEachIteration for GBTClassification and GBTRegressionModel
    
    ## How was this patch tested?
    
    doctest
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ludatabricks/spark-1 SPARK-14682

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21335
    
----
commit 4265a1a9deaf30185f7dee993979ef89afc18ee1
Author: Lu WANG <lu...@...>
Date:   2018-05-14T23:55:20Z

    add function in GBTClassifier

commit ae8eb4c0cf6d49259d174390f8ccd8a8fbe674cc
Author: Lu WANG <lu...@...>
Date:   2018-05-15T17:34:50Z

    add evaluateEachIteration to GBTClassificationModel and GBTRegressionModel

commit c25c5a6c2b4bff44816a8760a38877844f532141
Author: Lu WANG <lu...@...>
Date:   2018-05-15T17:40:50Z

    fix minor typos

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/21335


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90653/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    **[Test build #90655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90655/testReport)** for PR 21335 at commit [`5765049`](https://github.com/apache/spark/commit/57650498339ef3d10763e90babe0ef0c4c1d9f37).
     * This patch **fails Python style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    **[Test build #90657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90657/testReport)** for PR 21335 at commit [`d02797c`](https://github.com/apache/spark/commit/d02797c43c716f310e09487f3477139b47f50590).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    **[Test build #90655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90655/testReport)** for PR 21335 at commit [`5765049`](https://github.com/apache/spark/commit/57650498339ef3d10763e90babe0ef0c4c1d9f37).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    **[Test build #90653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90653/testReport)** for PR 21335 at commit [`c25c5a6`](https://github.com/apache/spark/commit/c25c5a6c2b4bff44816a8760a38877844f532141).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    LGTM. Merged into master. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90655/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    **[Test build #90658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90658/testReport)** for PR 21335 at commit [`17be21c`](https://github.com/apache/spark/commit/17be21c86683afa97f63217917992a5a2d3d8d83).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90657/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    **[Test build #90653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90653/testReport)** for PR 21335 at commit [`c25c5a6`](https://github.com/apache/spark/commit/c25c5a6c2b4bff44816a8760a38877844f532141).
     * This patch **fails Python style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90658/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    **[Test build #90658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90658/testReport)** for PR 21335 at commit [`17be21c`](https://github.com/apache/spark/commit/17be21c86683afa97f63217917992a5a2d3d8d83).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    **[Test build #90657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90657/testReport)** for PR 21335 at commit [`d02797c`](https://github.com/apache/spark/commit/d02797c43c716f310e09487f3477139b47f50590).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21335: [SPARK-24231][PYSPARK][ML] Provide Python API for evalua...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21335
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org