[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4761: [TE] Centralized cache proof-of-concept for anomaly detection via Couchbase

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #4761: [TE] Centralized cache proof-of-concept for anomaly detection via Couchbase
URL: https://github.com/apache/incubator-pinot/pull/4761#discussion_r341462029
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/utils/ThirdeyeMetricsUtil.java
 ##########
 @@ -110,6 +110,15 @@ public Integer value() {
   public static final Counter datasourceExceptionCounter =
       metricsRegistry.newCounter(ThirdeyeMetricsUtil.class, "datasourceExceptionCounter");
 
+  public static final Counter couchbaseCallCounter =
 
 Review comment:
   Can we track the following?
   1. cache hit ratio
   2. cache miss ratio
   3. current cache capacity

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org