You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/16 11:25:53 UTC

[GitHub] [shardingsphere] menghaoranss opened a new pull request #6078: Support heart beat for sharding jdbc with springboot

menghaoranss opened a new pull request #6078:
URL: https://github.com/apache/shardingsphere/pull/6078


   For #5885 .
   
   Changes proposed in this pull request:
   - Support heart beat for sharding jdbc with springboot
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] kimmking merged pull request #6078: Support heart beat for sharding jdbc with springboot

Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #6078:
URL: https://github.com/apache/shardingsphere/pull/6078


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #6078: Support heart beat for sharding jdbc with springboot

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6078:
URL: https://github.com/apache/shardingsphere/pull/6078#issuecomment-644752630


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6078?src=pr&el=h1) Report
   > Merging [#6078](https://codecov.io/gh/apache/shardingsphere/pull/6078?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ebd642b085f34e13c9ee9dfc505edbdd93495b0e&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `31.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6078/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6078?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #6078   +/-   ##
   =========================================
     Coverage     53.10%   53.10%           
   - Complexity      438      439    +1     
   =========================================
     Files          1188     1190    +2     
     Lines         20943    20989   +46     
     Branches       3772     3774    +2     
   =========================================
   + Hits          11122    11147   +25     
   - Misses         9123     9141   +18     
   - Partials        698      701    +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6078?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/shardingsphere/cluster/facade/ClusterFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2ZhY2FkZS9DbHVzdGVyRmFjYWRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/cluster/heartbeat/ClusterHeartbeatInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9DbHVzdGVySGVhcnRiZWF0SW5zdGFuY2UuamF2YQ==) | `33.33% <0.00%> (-8.34%)` | `0.00 <0.00> (ø)` | |
   | [...e/cluster/heartbeat/task/HeartbeatTaskManager.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC90YXNrL0hlYXJ0YmVhdFRhc2tNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-30.00%)` | `0.00 <0.00> (ø)` | |
   | [...driver/jdbc/adapter/AbstractConnectionAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvQWJzdHJhY3RDb25uZWN0aW9uQWRhcHRlci5qYXZh) | `71.57% <ø> (-0.30%)` | `6.00 <0.00> (ø)` | |
   | [...stration/OrchestrationSpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLW9yY2hlc3RyYXRpb24tc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmctYm9vdC1zdGFydGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvYm9vdC9vcmNoZXN0cmF0aW9uL09yY2hlc3RyYXRpb25TcHJpbmdCb290Q29uZmlndXJhdGlvbi5qYXZh) | `62.50% <0.00%> (-29.81%)` | `0.00 <0.00> (ø)` | |
   | [...mmon/OrchestrationSpringBootRootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLW9yY2hlc3RyYXRpb24tc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmctYm9vdC1zdGFydGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvYm9vdC9vcmNoZXN0cmF0aW9uL2NvbW1vbi9PcmNoZXN0cmF0aW9uU3ByaW5nQm9vdFJvb3RDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/cluster/heartbeat/detect/HeartbeatHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvSGVhcnRiZWF0SGFuZGxlci5qYXZh) | `71.87% <33.33%> (-4.80%)` | `0.00 <0.00> (ø)` | |
   | [...ransaction/ShardingTransactionTypeInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXRyYW5zYWN0aW9uLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3ByaW5nL3RyYW5zYWN0aW9uL1NoYXJkaW5nVHJhbnNhY3Rpb25UeXBlSW50ZXJjZXB0b3IuamF2YQ==) | `88.23% <66.66%> (-11.77%)` | `1.00 <0.00> (ø)` | |
   | [.../listener/ClusterConfigurationChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL2xpc3RlbmVyL0NsdXN0ZXJDb25maWd1cmF0aW9uQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `80.00% <80.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../listener/ConfigurationChangedListenerManager.java](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL2xpc3RlbmVyL0NvbmZpZ3VyYXRpb25DaGFuZ2VkTGlzdGVuZXJNYW5hZ2VyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [38 more](https://codecov.io/gh/apache/shardingsphere/pull/6078/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6078?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6078?src=pr&el=footer). Last update [d5af0ff...ebb21bc](https://codecov.io/gh/apache/shardingsphere/pull/6078?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org