You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Denis Delangle <de...@gmail.com> on 2012/05/22 17:15:40 UTC
Reopen TAP5-698
Hello,
I fear https://issues.apache.org/jira/browse/TAP5-698 should be
reopen. I encountered it when migrating from T5.2 to T5.3.3.
I get something like this when clicking a link with parameters in PageTester
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1937)
at java.lang.String.substring(String.java:1904)
at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
That bug was corrected revision 896555 and put back revision 1185926.
The correction is trivial but have been done twice, so the bug is
still there.
The patch to apply is :
Index: src/main/java/org/apache/tapestry5/test/PageTester.java
===================================================================
--- src/main/java/org/apache/tapestry5/test/PageTester.java (revision 1341503)
+++ src/main/java/org/apache/tapestry5/test/PageTester.java (working copy)
@@ -342,7 +342,7 @@
request.clear().setPath(path);
if (comma > 0)
- decodeParametersIntoRequest(path.substring(comma + 1));
+ decodeParametersIntoRequest(linkPath.substring(comma + 1));
}
private void decodeParametersIntoRequest(String queryString)
I don't see any way to reopen the bug, should I open a new Issue ?
Regards,
Denis
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Reopen TAP5-698
Posted by Denis Delangle <de...@gmail.com>.
Thanks,
https://issues.apache.org/jira/browse/TAP5-1936 with a patch
Denis
2012/5/22 Howard Lewis Ship <hl...@gmail.com>:
> Yes, you may open a new issue and ideally link to the old issue.
>
> On Tue, May 22, 2012 at 8:15 AM, Denis Delangle
> <de...@gmail.com> wrote:
>> Hello,
>>
>> I fear https://issues.apache.org/jira/browse/TAP5-698 should be
>> reopen. I encountered it when migrating from T5.2 to T5.3.3.
>>
>> I get something like this when clicking a link with parameters in PageTester
>> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
>> at java.lang.String.substring(String.java:1937)
>> at java.lang.String.substring(String.java:1904)
>> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
>>
>> That bug was corrected revision 896555 and put back revision 1185926.
>> The correction is trivial but have been done twice, so the bug is
>> still there.
>>
>> The patch to apply is :
>>
>> Index: src/main/java/org/apache/tapestry5/test/PageTester.java
>> ===================================================================
>> --- src/main/java/org/apache/tapestry5/test/PageTester.java (revision 1341503)
>> +++ src/main/java/org/apache/tapestry5/test/PageTester.java (working copy)
>> @@ -342,7 +342,7 @@
>> request.clear().setPath(path);
>>
>> if (comma > 0)
>> - decodeParametersIntoRequest(path.substring(comma + 1));
>> + decodeParametersIntoRequest(linkPath.substring(comma + 1));
>> }
>>
>> private void decodeParametersIntoRequest(String queryString)
>>
>>
>>
>>
>> I don't see any way to reopen the bug, should I open a new Issue ?
>>
>> Regards,
>>
>> Denis
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Reopen TAP5-698
Posted by Howard Lewis Ship <hl...@gmail.com>.
Yes, you may open a new issue and ideally link to the old issue.
On Tue, May 22, 2012 at 8:15 AM, Denis Delangle
<de...@gmail.com> wrote:
> Hello,
>
> I fear https://issues.apache.org/jira/browse/TAP5-698 should be
> reopen. I encountered it when migrating from T5.2 to T5.3.3.
>
> I get something like this when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
>
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
>
> The patch to apply is :
>
> Index: src/main/java/org/apache/tapestry5/test/PageTester.java
> ===================================================================
> --- src/main/java/org/apache/tapestry5/test/PageTester.java (revision 1341503)
> +++ src/main/java/org/apache/tapestry5/test/PageTester.java (working copy)
> @@ -342,7 +342,7 @@
> request.clear().setPath(path);
>
> if (comma > 0)
> - decodeParametersIntoRequest(path.substring(comma + 1));
> + decodeParametersIntoRequest(linkPath.substring(comma + 1));
> }
>
> private void decodeParametersIntoRequest(String queryString)
>
>
>
>
> I don't see any way to reopen the bug, should I open a new Issue ?
>
> Regards,
>
> Denis
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org