[GitHub] [incubator-iceberg] rdblue commented on issue #153: [Baseline] Apply baseline linting to iceberg-core

[GitBox <gi...@apache.org>]

rdblue commented on issue #153: [Baseline] Apply baseline linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#issuecomment-484659126
 
 
   Thanks for all your work on this, @mccheah! It's looking close. I'd prefer to exclude the single-threaded method in Tasks because I think that's a lot harder to reason about when it is broken across the current set of methods. Plus, those methods are awkward. I'm all for reducing complexity when there is a clean and well-defined purpose for a method. Not so much when we have to use side-effects like passing in a list to pass exceptions back out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org