You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "stream2000 (via GitHub)" <gi...@apache.org> on 2023/07/25 08:20:20 UTC

[GitHub] [hudi] stream2000 commented on a diff in pull request #9211: [HUDI-6540] Support failed writes clean policy for Flink

stream2000 commented on code in PR #9211:
URL: https://github.com/apache/hudi/pull/9211#discussion_r1273176064


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java:
##########
@@ -95,6 +95,9 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
         DataStream<Object> pipeline = Pipelines.append(conf, rowType, dataStream, context.isBounded());
         if (OptionsResolver.needsAsyncClustering(conf)) {
           return Pipelines.cluster(conf, rowType, pipeline);
+        } else if (OptionsResolver.isLazyFailedWritesCleanPolicy(conf)) {

Review Comment:
   Should we also modify `HoodieFlinkStreamer` here? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org