You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:00:06 UTC
[GitHub] [beam] piotr-szuberski commented on a change in pull request #11809: [BEAM-10073] Add pubsub performance tests results to the grafana dashboards
piotr-szuberski commented on a change in pull request #11809:
URL: https://github.com/apache/beam/pull/11809#discussion_r430022185
##########
File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_IO_IT_Tests_Dataflow.json
##########
@@ -35,7 +35,7 @@
},
"hiddenSeries": false,
"id": 2,
- "interval": "",
+ "interval": "15h",
Review comment:
I chose 15h because this interval is set to the AutoJob in jenkins. The java FileBased dashboards have it set to this value (in this case 6h)
##########
File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_IO_IT_Tests_Dataflow.json
##########
@@ -261,6 +261,250 @@
"align": false,
"alignLevel": null
}
+ },
+ {
+ "aliasColors": {},
+ "bars": false,
+ "cacheTimeout": null,
+ "dashLength": 10,
+ "dashes": false,
+ "datasource": "BeamInfluxDB",
+ "fill": 1,
+ "fillGradient": 0,
+ "gridPos": {
+ "h": 9,
+ "w": 12,
+ "x": 0,
+ "y": 9
+ },
+ "hiddenSeries": false,
+ "id": 4,
+ "interval": "15h",
+ "legend": {
+ "avg": false,
+ "current": false,
+ "max": false,
+ "min": false,
+ "show": false,
+ "total": false,
+ "values": false
+ },
+ "lines": true,
+ "linewidth": 2,
+ "links": [],
+ "nullPointMode": "connected",
+ "options": {
+ "dataLinks": []
+ },
+ "percentage": false,
+ "pluginVersion": "6.7.2",
+ "pointradius": 2,
+ "points": true,
+ "renderer": "flot",
+ "seriesOverrides": [],
+ "spaceLength": 10,
+ "stack": false,
+ "steppedLine": false,
+ "targets": [
+ {
+ "alias": "read_time",
+ "groupBy": [
+ {
+ "params": [
+ "$__interval"
+ ],
+ "type": "time"
+ }
+ ],
+ "measurement": "python_bqio_read",
+ "orderByTime": "ASC",
+ "policy": "default",
+ "query": "SELECT mean(\"value\") FROM \"python_psio_2GB_results\" WHERE \"metric\" = \"pubsub_io_perf_read_runtime\" AND $timeFilter GROUP BY time($__interval), \"metric\"",
+ "rawQuery": true,
+ "refId": "A",
+ "resultFormat": "time_series",
+ "select": [
+ [
+ {
+ "params": [
+ "value"
+ ],
+ "type": "field"
+ },
+ {
+ "params": [],
+ "type": "mean"
+ }
+ ]
+ ],
+ "tags": []
+ }
+ ],
+ "thresholds": [],
+ "timeFrom": null,
+ "timeRegions": [],
+ "timeShift": null,
+ "title": "Reading 2GB of data | Pubsub IO",
Review comment:
Done
##########
File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_IO_IT_Tests_Dataflow.json
##########
@@ -35,7 +35,7 @@
},
"hiddenSeries": false,
"id": 2,
- "interval": "",
+ "interval": "15h",
Review comment:
I didn't dig into it, bu now it's clear. I changed to 24h
##########
File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_IO_IT_Tests_Dataflow.json
##########
@@ -35,7 +35,7 @@
},
"hiddenSeries": false,
"id": 2,
- "interval": "",
+ "interval": "15h",
Review comment:
I didn't dig into it and was distracted by other jobs that indeed run every few hours. But now it's clear. I changed to 24h
##########
File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_IO_IT_Tests_Dataflow.json
##########
@@ -35,7 +35,7 @@
},
"hiddenSeries": false,
"id": 2,
- "interval": "",
+ "interval": "15h",
Review comment:
I didn't dig into it and was distracted by other jobs that indeed run every few hours. But now the syntax of schedules is clear. I changed to 24h
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org