You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by to...@apache.org on 2018/08/31 18:51:24 UTC
[1/2] impala git commit: IMPALA-7443: Fix intermittent GVO failures
due to stale Maven cache
Repository: impala
Updated Branches:
refs/heads/2.x 07c704aef -> 7f44a99c8
IMPALA-7443: Fix intermittent GVO failures due to stale Maven cache
When switching to a new Maven repository, such as switching to a new
CDH_BUILD_NUMBER, Maven does not automatically pick up the new
repository. The patch forces Maven to run with -U on Jenkins to force
updating its local repository. The patch also puts some Jenkins jobs
into scripts in $IMPALA_HOME/bin/jenkins to make updating Jenkins jobs
easier.
Change-Id: I935fe911f74306e4dde38945868943b4a7579ae2
Reviewed-on: http://gerrit.cloudera.org:8080/11222
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/11366
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Fredy Wijaya <fw...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/4c2f35f4
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/4c2f35f4
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/4c2f35f4
Branch: refs/heads/2.x
Commit: 4c2f35f4056ece8febb881226780f510aee22490
Parents: 07c704a
Author: Fredy Wijaya <fw...@cloudera.com>
Authored: Tue Aug 14 14:59:46 2018 -0700
Committer: Fredy Wijaya <fw...@cloudera.com>
Committed: Thu Aug 30 22:37:29 2018 +0000
----------------------------------------------------------------------
bin/jenkins/all-tests.sh | 29 +++++++++++++++++++++++++
bin/jenkins/build-all-flag-combinations.sh | 2 ++
bin/jenkins/build-only.sh | 28 ++++++++++++++++++++++++
3 files changed, 59 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/4c2f35f4/bin/jenkins/all-tests.sh
----------------------------------------------------------------------
diff --git a/bin/jenkins/all-tests.sh b/bin/jenkins/all-tests.sh
new file mode 100644
index 0000000..7917358
--- /dev/null
+++ b/bin/jenkins/all-tests.sh
@@ -0,0 +1,29 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Run all Impala tests.
+
+set -euo pipefail
+trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+
+cd "${IMPALA_HOME}"
+
+export IMPALA_MAVEN_OPTIONS="-U"
+
+source bin/bootstrap_development.sh
+bin/run-all-tests.sh
http://git-wip-us.apache.org/repos/asf/impala/blob/4c2f35f4/bin/jenkins/build-all-flag-combinations.sh
----------------------------------------------------------------------
diff --git a/bin/jenkins/build-all-flag-combinations.sh b/bin/jenkins/build-all-flag-combinations.sh
index c0e0f6a..ec5b1c1 100755
--- a/bin/jenkins/build-all-flag-combinations.sh
+++ b/bin/jenkins/build-all-flag-combinations.sh
@@ -27,6 +27,8 @@
set -euo pipefail
trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+export IMPALA_MAVEN_OPTIONS="-U"
+
. bin/impala-config.sh
# These are configurations for buildall:
http://git-wip-us.apache.org/repos/asf/impala/blob/4c2f35f4/bin/jenkins/build-only.sh
----------------------------------------------------------------------
diff --git a/bin/jenkins/build-only.sh b/bin/jenkins/build-only.sh
new file mode 100644
index 0000000..d14ad6e
--- /dev/null
+++ b/bin/jenkins/build-only.sh
@@ -0,0 +1,28 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Only run an Impala build.
+
+set -euo pipefail
+trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+
+cd "${IMPALA_HOME}"
+
+export IMPALA_MAVEN_OPTIONS="-U"
+
+bin/bootstrap_build.sh
[2/2] impala git commit: IMPALA-7513: Fix Sentry compilation error in
2.x
Posted by to...@apache.org.
IMPALA-7513: Fix Sentry compilation error in 2.x
An update to Sentry 1.5.1-cdh5.16.0-SNAPSHOT broke the build. This patch
fixes it by uploading the new CDH components, which includes Sentry server
to make sure the Sentry client and server dependencies are coherent.
Testing:
- Ran FE tests
Change-Id: I99c1aba398ea798a80fbbf76b4c5f8ad289be2ad
Reviewed-on: http://gerrit.cloudera.org:8080/11362
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/7f44a99c
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/7f44a99c
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/7f44a99c
Branch: refs/heads/2.x
Commit: 7f44a99c8c2392f188937656617ceeac21a28d3e
Parents: 4c2f35f
Author: Fredy Wijaya <fw...@cloudera.com>
Authored: Thu Aug 30 12:32:11 2018 -0700
Committer: Fredy Wijaya <fw...@cloudera.com>
Committed: Fri Aug 31 13:06:02 2018 +0000
----------------------------------------------------------------------
.../apache/impala/catalog/AuthorizationPolicy.java | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/7f44a99c/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java b/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java
index bc83522..fd7fb56 100644
--- a/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java
+++ b/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java
@@ -24,7 +24,6 @@ import java.util.Set;
import org.apache.commons.net.ntp.TimeStamp;
import org.apache.log4j.Logger;
import org.apache.sentry.core.common.ActiveRoleSet;
-import org.apache.sentry.provider.cache.PrivilegeCache;
import org.apache.impala.thrift.TColumn;
import org.apache.impala.thrift.TPrivilege;
@@ -36,6 +35,7 @@ import com.google.common.base.Strings;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.google.common.collect.Sets;
+import org.apache.sentry.provider.cache.SentryPrivilegeCache;
/**
* A thread safe authorization policy cache, consisting of roles, groups that are
@@ -51,11 +51,11 @@ import com.google.common.collect.Sets;
* rather than embedding the role name. When a privilege is added to a role, we do
* a lookup to get the role ID to using the roleIds_ map.
* Acts as the backing cache for the Sentry cached based provider (which is why
- * PrivilegeCache is implemented).
+ * SentryPrivilegeCache is implemented).
* TODO: Instead of calling into Sentry to perform final authorization checks, we
* should parse/validate the privileges in Impala.
*/
-public class AuthorizationPolicy implements PrivilegeCache {
+public class AuthorizationPolicy implements SentryPrivilegeCache {
private static final Logger LOG = Logger.getLogger(AuthorizationPolicy.class);
// Cache of role names (case-insensitive) to role objects.
@@ -295,8 +295,14 @@ public class AuthorizationPolicy implements PrivilegeCache {
}
@Override
+ public Set<String> listPrivileges(Set<String> groups, Set<String> users,
+ ActiveRoleSet roleSet) {
+ return listPrivileges(groups, roleSet);
+ }
+
+ @Override
public void close() {
- // Nothing to do, but required by PrivilegeCache.
+ // Nothing to do, but required by SentryPrivilegeCache.
}
/**