You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2017/06/20 22:27:00 UTC
[jira] [Commented] (ARROW-1133) [C++] Convert all non-accessor
function names to PascalCase
[ https://issues.apache.org/jira/browse/ARROW-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056579#comment-16056579 ]
Wes McKinney commented on ARROW-1133:
-------------------------------------
The old guidance as "Functions that are very cheap to call may instead follow the style
-for variable names (all lower-case, with underscores between words).
-The rule of thumb is that such a function should be so cheap that you
-normally wouldn't bother caching its return value when calling it in
-a loop. A canonical example is an inline method that just returns one
-of the class's member variables."
> [C++] Convert all non-accessor function names to PascalCase
> -----------------------------------------------------------
>
> Key: ARROW-1133
> URL: https://issues.apache.org/jira/browse/ARROW-1133
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
>
> It seems Google has taken the "cheap functions can be lower case" out of their style guide. I've been asked enough about "which style to use" that I like the idea of UsePascalCaseForEverything https://github.com/google/styleguide/commit/db0a26320f3e930c6ea7225ed53539b4fb31310c#diff-26120df7bca3279afbf749017c778545R4277
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)