You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ek...@apache.org on 2018/10/26 00:00:26 UTC
hive git commit: HIVE-14516:
OrcInputFormat.SplitGenerator.callInternal() can be optimized (Igor Kryvenko
via Eugene Koifman)
Repository: hive
Updated Branches:
refs/heads/master a99be34a0 -> a26d9d166
HIVE-14516: OrcInputFormat.SplitGenerator.callInternal() can be optimized (Igor Kryvenko via Eugene Koifman)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/a26d9d16
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/a26d9d16
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/a26d9d16
Branch: refs/heads/master
Commit: a26d9d166064117152779267e78c6b7fdd2ba6ee
Parents: a99be34
Author: Igor Kryvenko <kr...@gmail.com>
Authored: Thu Oct 25 17:00:14 2018 -0700
Committer: Eugene Koifman <ek...@apache.org>
Committed: Thu Oct 25 17:00:14 2018 -0700
----------------------------------------------------------------------
.../java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/a26d9d16/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java b/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
index 25b2d48..720dbe5 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
@@ -1551,9 +1551,7 @@ public class OrcInputFormat implements InputFormat<NullWritable, OrcStruct>,
} else {
populateAndCacheStripeDetails();
boolean[] includeStripe = null;
- // We can't eliminate stripes if there are deltas because the
- // deltas may change the rows making them match the predicate. todo: See HIVE-14516.
- if ((deltas == null || deltas.isEmpty()) && context.sarg != null) {
+ if (context.sarg != null) {
String[] colNames =
extractNeededColNames((readerTypes == null ? fileTypes : readerTypes),
context.conf, readerIncluded, isOriginal);
@@ -2212,7 +2210,7 @@ public class OrcInputFormat implements InputFormat<NullWritable, OrcStruct>,
OrcFile.WriterVersion writerVersion,
List<StripeStatistics> stripeStats,
int stripeCount, Path filePath, final SchemaEvolution evolution) {
- if (sarg == null || stripeStats == null || writerVersion == OrcFile.WriterVersion.ORIGINAL) {
+ if (stripeStats == null || writerVersion == OrcFile.WriterVersion.ORIGINAL) {
return null; // only do split pruning if HIVE-8732 has been fixed in the writer
}
// eliminate stripes that doesn't satisfy the predicate condition